feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QuickFixes: Always show all matching quick fixes.

Browse Source 
Change-Id: Ifc23d047b3b267ca1369ecb6f9f5de18887d3e92
Reviewed-on: http://codereview.qt.nokia.com/3250
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
This commit is contained in:
Christian Kamm
2011-08-19 10:24:09 +02:00
parent f725c24c56
commit a07acad516
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/texteditor/codeassist/quickfixassistprocessor.cpp
View File

@@ -72,12 +72,19 @@ IAssistProposal *QuickFixAssistProcessor::perform(const IAssistInterface *interf
} }
QList<QuickFixOperation::Ptr> quickFixes; QList<QuickFixOperation::Ptr> quickFixes;
// ### As the list of quick fixes grows, introduce some way of only showing relevant ones.
// The old priority-based way where the priority is the matching ast-node depth does not
// work well.
foreach (const QList<QuickFixOperation::Ptr> &fixes, matchedOps)
quickFixes += fixes;
#if 0
QMapIterator<int, QList<QuickFixOperation::Ptr> > it(matchedOps); QMapIterator<int, QList<QuickFixOperation::Ptr> > it(matchedOps);
it.toBack(); it.toBack();
if (it.hasPrevious()) { if (it.hasPrevious()) {
it.previous(); it.previous();
quickFixes = it.value(); quickFixes = it.value();
} }
#endif
if (!quickFixes.isEmpty()) { if (!quickFixes.isEmpty()) {
QList<BasicProposalItem *> items; QList<BasicProposalItem *> items;