Vcs: Distribute readSettings() calls to individual settings

Isn't a benefit here, but what the other settings do, so it's easier
to ponder more centralized solutions later.

Change-Id: I3837e5bedc8771dd56b8bacda8c23e40281b4fe3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/bazaar/bazaarsettings.cpp

@@ -86,6 +86,8 @@ BazaarSettings::BazaarSettings()
             st
         };
     });
+
+    readSettings();
 }
 
 // BazaarSettingsPage

src/plugins/cvs/cvssettings.cpp

@@ -78,6 +78,8 @@ CvsSettings::CvsSettings()
             st
         };
     });
+
+    readSettings();
 }
 
 QStringList CvsSettings::addOptions(const QStringList &args) const

src/plugins/fossil/fossilsettings.cpp

@@ -115,6 +115,8 @@ FossilSettings::FossilSettings()
             st
         };
     });
+
+    readSettings();
 }
 
 // FossilSettingsPage

src/plugins/git/gitsettings.cpp

@@ -145,6 +145,8 @@ GitSettings::GitSettings()
     });
     connect(&binaryPath, &BaseAspect::changed, this, [this] { tryResolve = true; });
     connect(&path, &BaseAspect::changed, this, [this] { tryResolve = true; });
+
+    readSettings();
 }
 
 FilePath GitSettings::gitExecutable(bool *ok, QString *errorMessage) const

src/plugins/mercurial/mercurialsettings.cpp

@@ -70,6 +70,8 @@ MercurialSettings::MercurialSettings()
             st
         };
     });
+
+    readSettings();
 }
 
 // MercurialSettingsPage

src/plugins/subversion/subversionsettings.cpp

@@ -94,6 +94,8 @@ SubversionSettings::SubversionSettings()
             st
         };
     });
+
+    readSettings();
 }
 
 bool SubversionSettings::hasAuthentication() const

src/plugins/vcsbase/vcsbaseclient.cpp

@@ -57,7 +57,6 @@ namespace VcsBase {
 VcsBaseClientImpl::VcsBaseClientImpl(VcsBaseSettings *baseSettings)
     : m_baseSettings(baseSettings)
 {
-    m_baseSettings->readSettings();
     connect(ICore::instance(), &ICore::saveSettingsRequested,
             this, &VcsBaseClientImpl::saveSettings);
 }