CMakePM: Add "CMake Install" deployment step

This commit adds a "CMake Install" deployment step, which is using "cmake --install" command. "cmake --install" command has been added in CMake 3.15, this is why the minimum CMake version has been updated to 3.15. Note that CMakeBuildSystem::makeInstallCommand is still using cmake -- build --target install due to a CMake bug regarding "Ninja Multi-Config" generator, which doesn't intall all binaries via "cmake --install". Fixes: QTCREATORBUG-25880 Change-Id: I504674c380055d8ef136d344a78b80c17ecf9765 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-12-09 18:44:42 +01:00
parent 2eb2aa13ae
commit a0afd51f3f
12 changed files with 270 additions and 46 deletions
--- a/src/plugins/cmakeprojectmanager/cmakeabstractprocessstep.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakeabstractprocessstep.cpp
@@ -0,0 +1,66 @@
+// Copyright (C) 2022 The Qt Company Ltd.
+// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0+ OR GPL-3.0 WITH Qt-GPL-exception-1.0
+
+#include "cmakeabstractprocessstep.h"
+
+#include "cmakekitinformation.h"
+#include "cmakeprojectmanagertr.h"
+#include "cmaketool.h"
+
+#include <projectexplorer/buildsteplist.h>
+#include <projectexplorer/project.h>
+#include <projectexplorer/target.h>
+
+using namespace Core;
+using namespace ProjectExplorer;
+using namespace Utils;
+
+namespace CMakeProjectManager::Internal {
+
+// CMakeAbstractProcessStep
+
+CMakeAbstractProcessStep::CMakeAbstractProcessStep(BuildStepList *bsl, Utils::Id id)
+    : AbstractProcessStep(bsl, id)
+{}
+
+bool CMakeAbstractProcessStep::init()
+{
+    if (!AbstractProcessStep::init())
+        return false;
+
+    BuildConfiguration *bc = buildConfiguration();
+    QTC_ASSERT(bc, return false);
+
+    if (!bc->isEnabled()) {
+        emit addTask(
+            BuildSystemTask(Task::Error, Tr::tr("The build configuration is currently disabled.")));
+        emitFaultyConfigurationMessage();
+        return false;
+    }
+
+    CMakeTool *tool = CMakeKitAspect::cmakeTool(kit());
+    if (!tool || !tool->isValid()) {
+        emit addTask(BuildSystemTask(Task::Error,
+                                     Tr::tr("A CMake tool must be set up for building. "
+                                            "Configure a CMake tool in the kit options.")));
+        emitFaultyConfigurationMessage();
+        return false;
+    }
+
+    // Warn if doing out-of-source builds with a CMakeCache.txt is the source directory
+    const Utils::FilePath projectDirectory = bc->target()->project()->projectDirectory();
+    if (bc->buildDirectory() != projectDirectory) {
+        if (projectDirectory.pathAppended("CMakeCache.txt").exists()) {
+            emit addTask(BuildSystemTask(
+                Task::Warning,
+                Tr::tr("There is a CMakeCache.txt file in \"%1\", which suggest an "
+                       "in-source build was done before. You are now building in \"%2\", "
+                       "and the CMakeCache.txt file might confuse CMake.")
+                    .arg(projectDirectory.toUserOutput(), bc->buildDirectory().toUserOutput())));
+        }
+    }
+
+    return true;
+}
+
+} // namespace CMakeProjectManager::Internal