feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Analyzer Run Config: Turn tabs into group boxes

Browse Source 
Merge-request: 265
Reviewed-by: hjk <qtc-committer@nokia.com>
This commit is contained in:
Kevin Funk
2011-03-04 16:00:03 +01:00
committed by hjk
parent 4fff89d984
commit a1103e122e
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/analyzerbase/analyzerrunconfigwidget.cpp
View File

@@ -40,9 +40,8 @@
#include <utils/detailswidget.h> #include <utils/detailswidget.h>
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#include <QStandardItemModel>
#include <QFileDialog>
#include <QDebug> #include <QDebug>
#include <QGroupBox>
#include <QVBoxLayout> #include <QVBoxLayout>
using namespace Analyzer; using namespace Analyzer;
@@ -50,9 +49,11 @@ using namespace Analyzer::Internal;
AnalyzerRunConfigWidget::AnalyzerRunConfigWidget() AnalyzerRunConfigWidget::AnalyzerRunConfigWidget()
: m_detailsWidget(new Utils::DetailsWidget(this)) : m_detailsWidget(new Utils::DetailsWidget(this))
, m_tabWidget(new QTabWidget(this))
{ {
m_detailsWidget->setWidget(m_tabWidget); QWidget* mainWidget = new QWidget(this);
new QVBoxLayout(mainWidget);
m_detailsWidget->setWidget(mainWidget);
QVBoxLayout *layout = new QVBoxLayout(this); QVBoxLayout *layout = new QVBoxLayout(this);
layout->setContentsMargins(0, 0, 0, 0); layout->setContentsMargins(0, 0, 0, 0);
layout->addWidget(m_detailsWidget); layout->addWidget(m_detailsWidget);
@@ -66,7 +67,6 @@ QString AnalyzerRunConfigWidget::displayName() const
void AnalyzerRunConfigWidget::setRunConfiguration(ProjectExplorer::RunConfiguration *rc) void AnalyzerRunConfigWidget::setRunConfiguration(ProjectExplorer::RunConfiguration *rc)
{ {
QTC_ASSERT(rc, return); QTC_ASSERT(rc, return);
m_tabWidget->clear();
AnalyzerProjectSettings *settings = rc->extraAspect<AnalyzerProjectSettings>(); AnalyzerProjectSettings *settings = rc->extraAspect<AnalyzerProjectSettings>();
QTC_ASSERT(settings, return); QTC_ASSERT(settings, return);
@@ -78,8 +78,11 @@ void AnalyzerRunConfigWidget::setRunConfiguration(ProjectExplorer::RunConfigurat
} }
m_detailsWidget->setSummaryText(tr("Available settings: %1").arg(tools.join(", "))); m_detailsWidget->setSummaryText(tr("Available settings: %1").arg(tools.join(", ")));
// add tabs for each config // add group boxes for each sub config
QLayout* layout = m_detailsWidget->widget()->layout();
foreach(AbstractAnalyzerSubConfig *config, settings->subConfigs()) { foreach(AbstractAnalyzerSubConfig *config, settings->subConfigs()) {
m_tabWidget->addTab(config->createConfigWidget(this), config->displayName()); QGroupBox* box = new QGroupBox(config->displayName());
QWidget* widget = config->createConfigWidget(this);
layout->addWidget(widget);
} }
} }

6
src/plugins/analyzerbase/analyzerrunconfigwidget.h
View File

@@ -39,8 +39,6 @@
#include <projectexplorer/runconfiguration.h> #include <projectexplorer/runconfiguration.h>
#include <QTabWidget>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QStandardItemModel; class QStandardItemModel;
@@ -66,12 +64,12 @@ class AnalyzerRunConfigWidget : public ProjectExplorer::RunConfigWidget
public: public:
AnalyzerRunConfigWidget(); AnalyzerRunConfigWidget();
QString displayName() const; virtual QString displayName() const;
void setRunConfiguration(ProjectExplorer::RunConfiguration *rc); void setRunConfiguration(ProjectExplorer::RunConfiguration *rc);
private: private:
Utils::DetailsWidget *m_detailsWidget; Utils::DetailsWidget *m_detailsWidget;
QTabWidget *m_tabWidget;
}; };
} }