Remove unnecessary destructors

Change-Id: Id0bc2d3a305e6af24838266195ab22e04e3a12a1
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>

src/plugins/baremetal/baremetalgdbcommandsdeploystep.cpp

@@ -84,10 +84,6 @@ void BareMetalGdbCommandsDeployStep::ctor()
     setDefaultDisplayName(displayName());
 }
 
-BareMetalGdbCommandsDeployStep::~BareMetalGdbCommandsDeployStep()
-{
-}
-
 void BareMetalGdbCommandsDeployStep::run(QFutureInterface<bool> &fi)
 {
     fi.reportResult(true);

src/plugins/baremetal/baremetalgdbcommandsdeploystep.h

@@ -47,7 +47,6 @@ public:
     BareMetalGdbCommandsDeployStep(ProjectExplorer::BuildStepList *bsl, Core::Id id);
     BareMetalGdbCommandsDeployStep(ProjectExplorer::BuildStepList *bsl,
                                    BareMetalGdbCommandsDeployStep *other);
-    ~BareMetalGdbCommandsDeployStep() override;
 
     bool init() override;
     void run(QFutureInterface<bool> &fi) override;

src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp

@@ -92,10 +92,6 @@ CMakeRunConfiguration::CMakeRunConfiguration(Target *parent, CMakeRunConfigurati
     ctor();
 }
 
-CMakeRunConfiguration::~CMakeRunConfiguration()
-{
-}
-
 void CMakeRunConfiguration::ctor()
 {
     setDefaultDisplayName(defaultDisplayName());

src/plugins/cmakeprojectmanager/cmakerunconfiguration.h

@@ -57,7 +57,6 @@ class CMakeRunConfiguration : public ProjectExplorer::LocalApplicationRunConfigu
 public:
     CMakeRunConfiguration(ProjectExplorer::Target *parent, Core::Id id, const QString &target,
                           const QString &workingDirectory, const QString &title);
-    ~CMakeRunConfiguration() override;
 
     QString executable() const override;
     ProjectExplorer::ApplicationLauncher::Mode runMode() const override;

src/plugins/cmakeprojectmanager/makestep.cpp

@@ -115,10 +115,6 @@ void MakeStep::ctor()
             this, &MakeStep::buildTargetsChanged);
 }
 
-MakeStep::~MakeStep()
-{
-}
-
 CMakeBuildConfiguration *MakeStep::cmakeBuildConfiguration() const
 {
     return static_cast<CMakeBuildConfiguration *>(buildConfiguration());

src/plugins/cmakeprojectmanager/makestep.h

@@ -56,7 +56,6 @@ class MakeStep : public ProjectExplorer::AbstractProcessStep
 
 public:
     explicit MakeStep(ProjectExplorer::BuildStepList *bsl);
-    ~MakeStep() override;
 
     CMakeBuildConfiguration *cmakeBuildConfiguration() const;
 

src/plugins/genericprojectmanager/genericmakestep.cpp

@@ -94,10 +94,6 @@ void GenericMakeStep::ctor()
                                                       GENERIC_MS_DISPLAY_NAME));
 }
 
-GenericMakeStep::~GenericMakeStep()
-{
-}
-
 bool GenericMakeStep::init()
 {
     BuildConfiguration *bc = buildConfiguration();

src/plugins/genericprojectmanager/genericmakestep.h

@@ -53,7 +53,6 @@ class GenericMakeStep : public ProjectExplorer::AbstractProcessStep
 
 public:
     explicit GenericMakeStep(ProjectExplorer::BuildStepList *parent);
-    ~GenericMakeStep() override;
 
     bool init() override;
     void run(QFutureInterface<bool> &fi) override;

src/plugins/ios/iosbuildstep.cpp

@@ -95,10 +95,6 @@ void IosBuildStep::ctor()
                                                       IOS_BUILD_STEP_DISPLAY_NAME));
 }
 
-IosBuildStep::~IosBuildStep()
-{
-}
-
 bool IosBuildStep::init()
 {
     BuildConfiguration *bc = buildConfiguration();

src/plugins/ios/iosbuildstep.h

@@ -52,7 +52,6 @@ class IosBuildStep : public ProjectExplorer::AbstractProcessStep
 
 public:
     explicit IosBuildStep(ProjectExplorer::BuildStepList *parent);
-    ~IosBuildStep() override;
 
     bool init() override;
     void run(QFutureInterface<bool> &fi) override;

src/plugins/ios/iosdeploystep.cpp

@@ -76,8 +76,6 @@ IosDeployStep::IosDeployStep(BuildStepList *parent,
     ctor();
 }
 
-IosDeployStep::~IosDeployStep() { }
-
 void IosDeployStep::ctor()
 {
     m_toolHandler = 0;

src/plugins/ios/iosdeploystep.h

@@ -66,8 +66,6 @@ public:
     friend class IosDeployStepFactory;
     explicit IosDeployStep(ProjectExplorer::BuildStepList *bc);
 
-    ~IosDeployStep() override;
-
     bool fromMap(const QVariantMap &map) override;
     QVariantMap toMap() const override;
 

src/plugins/ios/iosdsymbuildstep.cpp

@@ -84,10 +84,6 @@ bool IosPresetBuildStep::completeSetupWithStep(BuildStep *bs)
     return true;
 }
 
-IosPresetBuildStep::~IosPresetBuildStep()
-{
-}
-
 bool IosPresetBuildStep::init()
 {
     BuildConfiguration *bc = buildConfiguration();

src/plugins/ios/iosdsymbuildstep.h

@@ -47,8 +47,6 @@ class IosPresetBuildStep : public ProjectExplorer::AbstractProcessStep
     friend class IosPresetBuildStepFactory;
 
 public:
-    ~IosPresetBuildStep() override;
-
     bool init() override;
     void run(QFutureInterface<bool> &fi) override;
 

src/plugins/projectexplorer/buildconfiguration.cpp

@@ -113,10 +113,6 @@ void BuildConfiguration::ctor()
             [this] { return displayName(); }, false);
 }
 
-BuildConfiguration::~BuildConfiguration()
-{
-}
-
 Utils::FileName BuildConfiguration::buildDirectory() const
 {
     QString path = QDir::cleanPath(environment().expandVariables(m_buildDirectory.toString()));

src/plugins/projectexplorer/buildconfiguration.h

@@ -53,7 +53,6 @@ class PROJECTEXPLORER_EXPORT BuildConfiguration : public ProjectConfiguration
 
 public:
     // ctors are protected
-    ~BuildConfiguration() override;
 
     Utils::FileName buildDirectory() const;
     Utils::FileName rawBuildDirectory() const;

src/plugins/projectexplorer/buildstep.cpp

@@ -127,10 +127,6 @@ BuildStep::BuildStep(BuildStepList *bsl, BuildStep *bs) :
     setDisplayName(bs->displayName());
 }
 
-BuildStep::~BuildStep()
-{
-}
-
 bool BuildStep::fromMap(const QVariantMap &map)
 {
     m_enabled = map.value(QLatin1String(buildStepEnabledKey), true).toBool();

src/plugins/projectexplorer/buildstep.h

@@ -56,8 +56,6 @@ protected:
     BuildStep(BuildStepList *bsl, BuildStep *bs);
 
 public:
-    ~BuildStep() override;
-
     virtual bool init() = 0;
 
     virtual void run(QFutureInterface<bool> &fi) = 0;

src/plugins/projectexplorer/localapplicationrunconfiguration.cpp

@@ -51,10 +51,6 @@ LocalApplicationRunConfiguration::LocalApplicationRunConfiguration(Target *targe
 {
 }
 
-LocalApplicationRunConfiguration::~LocalApplicationRunConfiguration()
-{
-}
-
 void LocalApplicationRunConfiguration::addToBaseEnvironment(Utils::Environment &env) const
 {
     Q_UNUSED(env);

src/plugins/projectexplorer/localapplicationrunconfiguration.h

@@ -42,8 +42,6 @@ class PROJECTEXPLORER_EXPORT LocalApplicationRunConfiguration : public RunConfig
 {
     Q_OBJECT
 public:
-    ~LocalApplicationRunConfiguration() override;
-
     virtual QString executable() const = 0;
     virtual ApplicationLauncher::Mode runMode() const = 0;
     virtual QString workingDirectory() const = 0;

src/plugins/projectexplorer/processstep.cpp

@@ -72,10 +72,6 @@ void ProcessStep::ctor()
         m_workingDirectory = QLatin1String(Constants::DEFAULT_WORKING_DIR);
 }
 
-ProcessStep::~ProcessStep()
-{
-}
-
 bool ProcessStep::init()
 {
     BuildConfiguration *bc = buildConfiguration();

src/plugins/projectexplorer/processstep.h

@@ -64,7 +64,6 @@ class ProcessStep : public AbstractProcessStep
 
 public:
     explicit ProcessStep(BuildStepList *bsl);
-    ~ProcessStep() override;
 
     bool init() override;
     void run(QFutureInterface<bool> &) override;

src/plugins/qmakeandroidsupport/androidpackageinstallationstep.h

@@ -52,7 +52,7 @@ public:
     void run(QFutureInterface<bool> &fi) override;
 private:
     AndroidPackageInstallationStep(ProjectExplorer::BuildStepList *bc,
-        AndroidPackageInstallationStep *other);
+                                   AndroidPackageInstallationStep *other);
     QStringList m_androidDirsToClean;
     static const Core::Id Id;
 };

src/plugins/qmakeandroidsupport/qmakeandroidbuildapkstep.h

@@ -71,8 +71,7 @@ public:
 
 protected:
     friend class QmakeAndroidBuildApkStepFactory;
-    QmakeAndroidBuildApkStep(ProjectExplorer::BuildStepList *bc,
+    QmakeAndroidBuildApkStep(ProjectExplorer::BuildStepList *bc, QmakeAndroidBuildApkStep *other);
-        QmakeAndroidBuildApkStep *other);
 
     Utils::FileName androidPackageSourceDir() const override;
 

src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.cpp

@@ -110,10 +110,6 @@ DesktopQmakeRunConfiguration::DesktopQmakeRunConfiguration(Target *parent, Deskt
     ctor();
 }
 
-DesktopQmakeRunConfiguration::~DesktopQmakeRunConfiguration()
-{
-}
-
 bool DesktopQmakeRunConfiguration::isEnabled() const
 {
     return m_parseSuccess && !m_parseInProgress;

src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.h

@@ -69,7 +69,6 @@ class DesktopQmakeRunConfiguration : public ProjectExplorer::LocalApplicationRun
 
 public:
     DesktopQmakeRunConfiguration(ProjectExplorer::Target *parent, Core::Id id);
-    ~DesktopQmakeRunConfiguration() override;
 
     bool isEnabled() const override;
     QString disabledReason() const override;

src/plugins/qmakeprojectmanager/makestep.cpp

@@ -93,10 +93,6 @@ void MakeStep::setMakeCommand(const QString &make)
     m_makeCmd = make;
 }
 
-MakeStep::~MakeStep()
-{
-}
-
 QmakeBuildConfiguration *MakeStep::qmakeBuildConfiguration() const
 {
     return static_cast<QmakeBuildConfiguration *>(buildConfiguration());

src/plugins/qmakeprojectmanager/makestep.h

@@ -80,7 +80,6 @@ class QMAKEPROJECTMANAGER_EXPORT MakeStep : public ProjectExplorer::AbstractProc
 
 public:
     explicit MakeStep(ProjectExplorer::BuildStepList *bsl);
-    ~MakeStep() override;
 
     QmakeBuildConfiguration *qmakeBuildConfiguration() const;
 

src/plugins/qmakeprojectmanager/qmakestep.cpp

@@ -105,10 +105,6 @@ void QMakeStep::ctor()
     setDefaultDisplayName(tr("qmake"));
 }
 
-QMakeStep::~QMakeStep()
-{
-}
-
 QmakeBuildConfiguration *QMakeStep::qmakeBuildConfiguration() const
 {
     return static_cast<QmakeBuildConfiguration *>(buildConfiguration());

src/plugins/qmakeprojectmanager/qmakestep.h

@@ -129,7 +129,6 @@ class QMAKEPROJECTMANAGER_EXPORT QMakeStep : public ProjectExplorer::AbstractPro
 
 public:
     explicit QMakeStep(ProjectExplorer::BuildStepList *parent);
-    ~QMakeStep() override;
 
     QmakeBuildConfiguration *qmakeBuildConfiguration() const;
     bool init() override;

src/plugins/remotelinux/abstractremotelinuxrunconfiguration.cpp

@@ -39,11 +39,6 @@ AbstractRemoteLinuxRunConfiguration::AbstractRemoteLinuxRunConfiguration(Project
 
 }
 
-AbstractRemoteLinuxRunConfiguration::~AbstractRemoteLinuxRunConfiguration()
-{
-
-}
-
 AbstractRemoteLinuxRunConfiguration::AbstractRemoteLinuxRunConfiguration(ProjectExplorer::Target *parent,
         AbstractRemoteLinuxRunConfiguration *source): RunConfiguration(parent, source)
 {

src/plugins/remotelinux/abstractremotelinuxrunconfiguration.h

@@ -48,8 +48,6 @@ class REMOTELINUX_EXPORT AbstractRemoteLinuxRunConfiguration :
 public:
     AbstractRemoteLinuxRunConfiguration(ProjectExplorer::Target *parent, Core::Id id);
 
-    ~AbstractRemoteLinuxRunConfiguration() override;
-
     virtual QString localExecutableFilePath() const = 0;
     virtual QString remoteExecutableFilePath() const = 0;
     virtual QStringList arguments() const = 0;