From a111a6844231b74f8b8a093f108c04acb014a5e5 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Tue, 31 Aug 2021 06:31:13 +0200 Subject: [PATCH] LanguageClient: stop documentHighlights timer on document changes If the position was changed right before the document was edited the timer might still be running. Change-Id: Ieaa4de5cc10f25e6d58afaf9525417e11a34d1db Reviewed-by: Christian Kandeler --- src/plugins/languageclient/client.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/plugins/languageclient/client.cpp b/src/plugins/languageclient/client.cpp index 4015e386230..c70e87efa3a 100644 --- a/src/plugins/languageclient/client.cpp +++ b/src/plugins/languageclient/client.cpp @@ -723,12 +723,11 @@ void Client::documentContentsChanged(TextEditor::TextDocument *document, using namespace TextEditor; for (BaseTextEditor *editor : BaseTextEditor::textEditorsForDocument(document)) { - if (TextEditorWidget *widget = editor->editorWidget()) { - widget->setRefactorMarkers( - RefactorMarker::filterOutType(widget->refactorMarkers(), id())); - } + TextEditorWidget *widget = editor->editorWidget(); + QTC_ASSERT(widget, continue); + delete m_documentHighlightsTimer.take(widget); + widget->setRefactorMarkers(RefactorMarker::filterOutType(widget->refactorMarkers(), id())); } - m_documentUpdateTimer.start(); }