feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AbstractRemoteLinuxDeployStep: Get rid of run preparer

Browse Source 
Make it a part of isDeploymentNecessary() instead.

Change-Id: I73bda4f75b94222b6e9475b13a373f7237969999
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2023-07-07 12:16:29 +02:00
parent 243341df46
commit a119242771
4 changed files with 6 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/remotelinux/abstractremotelinuxdeploystep.cpp
View File

@@ -31,7 +31,6 @@ class AbstractRemoteLinuxDeployStepPrivate
public:
bool hasError;
std::function<expected_str<void>()> internalInit;
std::function<void()> runPreparer;
DeploymentTimeInfo deployTimes;
std::unique_ptr<TaskTree> m_taskTree;
@@ -86,11 +85,6 @@ void AbstractRemoteLinuxDeployStep::setInternalInitializer(
d->internalInit = init;
}
void AbstractRemoteLinuxDeployStep::setRunPreparer(const std::function<void ()> &prep)
{
d->runPreparer = prep;
}
bool AbstractRemoteLinuxDeployStep::fromMap(const QVariantMap &map)
{
if (!BuildStep::fromMap(map))
@@ -119,9 +113,6 @@ bool AbstractRemoteLinuxDeployStep::init()
void AbstractRemoteLinuxDeployStep::doRun()
{
if (d->runPreparer)
d->runPreparer();
d->hasError = false;
QTC_ASSERT(!d->m_taskTree, return);