feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakeSpecificSettingsPage: delete SettingsWidget

Browse Source 
Also added Q_OBJECT macro, for tr call in ctor.

Change-Id: I4766b6299a07e3ba0ebc8577e9f4471021b89f07
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Nikita Baryshnikov
2018-03-23 13:55:16 +03:00
parent cf4dbb4bb6
commit a16d712c11
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cmakeprojectmanager/cmakespecificsettingspage.cpp
View File

@@ -102,5 +102,11 @@ void CMakeSpecificSettingsPage::apply()
m_settings->toSettings(Core::ICore::settings()); m_settings->toSettings(Core::ICore::settings());
} }
void CMakeSpecificSettingsPage::finish()
{
delete m_widget;
m_widget = nullptr;
}
} // Internal } // Internal
} // CMakeProjectManager } // CMakeProjectManager

5
src/plugins/cmakeprojectmanager/cmakespecificsettingspage.h
View File

@@ -52,15 +52,16 @@ private:
class CMakeSpecificSettingsPage : public Core::IOptionsPage class CMakeSpecificSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT
public: public:
CMakeSpecificSettingsPage(CMakeSpecificSettings *settings, QObject *parent); CMakeSpecificSettingsPage(CMakeSpecificSettings *settings, QObject *parent);
QWidget *widget() override; QWidget *widget() override;
void apply() override; void apply() override;
void finish() override { } void finish() override;
private: private:
CMakeSpecificSettings * const m_settings; CMakeSpecificSettings * const m_settings = nullptr;
QPointer<CMakeSpecificSettingWidget> m_widget; QPointer<CMakeSpecificSettingWidget> m_widget;
}; };