feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: Do not reconfigure project on KitUpdated

Browse Source 
Initial Configuration will get the updated kit values and it's
up to the user to react.

The reconfiguration doesn't help at all, since none of
the variables / options ends up in the Current Configuration.

Change-Id: I5ee75fce1a33ce30a011ce6f1b6399fd79727ca6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Cristian Adam
2022-02-09 11:07:15 +01:00
parent 14ee4654c1
commit a204ad3236
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
View File

@@ -805,17 +805,6 @@ void CMakeBuildSystem::wireUpConnections()
// At this point the entire project will be fully configured, so let's connect everything and // At this point the entire project will be fully configured, so let's connect everything and
// trigger an initial parser run // trigger an initial parser run
// Kit changed:
connect(KitManager::instance(), &KitManager::kitUpdated, this, [this](Kit *k) {
if (k != kit())
return; // not for us...
// FIXME: This is no longer correct: QtC now needs to update the initial parameters
// FIXME: and then ask to reconfigure.
qCDebug(cmakeBuildSystemLog) << "Requesting parse due to kit being updated";
setParametersAndRequestParse(BuildDirParameters(cmakeBuildConfiguration()),
CMakeBuildSystem::REPARSE_FORCE_CMAKE_RUN);
});
// Became active/inactive: // Became active/inactive:
connect(target(), &Target::activeBuildConfigurationChanged, this, [this]() { connect(target(), &Target::activeBuildConfigurationChanged, this, [this]() {
// Build configuration has changed: // Build configuration has changed: