From a25ea9febe513bdd3a4d342eb29f0df834d41103 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Fri, 26 Mar 2021 07:36:14 +0100 Subject: [PATCH] Android/iOS: Don't add markup to display names of build steps The display name is continuously read and written from/to settings. Let's not add markup each occurrence, it accumulates. BuildStep::summaryText has the logic to add the markup for the UI. Change-Id: Ifbb74ccb8d2f0adcebbd69cc012a5b1376154934 Reviewed-by: Eike Ziller Reviewed-by: hjk --- src/plugins/android/androiddeployqtstep.cpp | 3 --- src/plugins/ios/iosdeploystep.cpp | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/plugins/android/androiddeployqtstep.cpp b/src/plugins/android/androiddeployqtstep.cpp index d3546e3e8f6..b8a822b30b5 100644 --- a/src/plugins/android/androiddeployqtstep.cpp +++ b/src/plugins/android/androiddeployqtstep.cpp @@ -494,9 +494,6 @@ QWidget *AndroidDeployQtStep::createConfigWidget() { auto widget = new QWidget; - setDisplayName(QString("%1").arg(displayName())); - setSummaryText(displayName()); - auto resetDefaultDevices = new QPushButton(widget); resetDefaultDevices->setText(tr("Reset Default Deployment Devices")); diff --git a/src/plugins/ios/iosdeploystep.cpp b/src/plugins/ios/iosdeploystep.cpp index 0d24378a5af..6fbc08f5f76 100644 --- a/src/plugins/ios/iosdeploystep.cpp +++ b/src/plugins/ios/iosdeploystep.cpp @@ -235,8 +235,6 @@ QWidget *IosDeployStep::createConfigWidget() auto widget = new QWidget; widget->setObjectName("IosDeployStepWidget"); - setDisplayName(QString("%1").arg(displayName())); - setSummaryText(displayName()); connect(this, &ProjectConfiguration::displayNameChanged, this, &BuildStep::updateSummary);