feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Consolidate more aspect functionality

Browse Source 
The concepts of 'value', 'defaultValue' and changed signals are present
in a few aspects, with varying implementations. Time to get things
sorted out.

The values are stored now as QVariant in the base, with typed accessors
in the derived classes, keeping the user visible interface the same.

Change-Id: I4d37ef5c7a9795f46ce1bbbabc6a251222b1d54e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2021-02-17 14:11:58 +01:00
parent acd33a45d8
commit a2d6c2b34a
4 changed files with 153 additions and 227 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/ios/iosbuildconfiguration.cpp
View File

@@ -408,6 +408,7 @@ IosQmakeBuildConfiguration::IosQmakeBuildConfiguration(Target *target, Utils::Id
m_autoManagedSigning = addAspect<BoolAspect>();
m_autoManagedSigning->setDefaultValue(true);
m_autoManagedSigning->setValue(true);
m_autoManagedSigning->setSettingsKey(autoManagedSigningKey);
connect(m_signingIdentifier,
@@ -506,6 +507,7 @@ IosCMakeBuildConfiguration::IosCMakeBuildConfiguration(Target *target, Id id)
m_autoManagedSigning = addAspect<BoolAspect>();
m_autoManagedSigning->setDefaultValue(true);
m_autoManagedSigning->setValue(true);
m_autoManagedSigning->setSettingsKey(autoManagedSigningKey);
connect(m_signingIdentifier,