feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlPuppet: Replace some foreach

Browse Source 
Change-Id: I59b4049282564762f75aa5e9a7a0b7eba055db48
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2019-07-25 16:58:50 +02:00
parent a6c85993ba
commit a34bf6a23b
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
share/qtcreator/qml/qmlpuppet/commands/valueschangedcommand.cpp
View File

@@ -62,7 +62,7 @@ quint32 ValuesChangedCommand::keyNumber() const
void ValuesChangedCommand::removeSharedMemorys(const QVector<qint32> &keyNumberVector) void ValuesChangedCommand::removeSharedMemorys(const QVector<qint32> &keyNumberVector)
{ {
foreach (qint32 keyNumber, keyNumberVector) { for (qint32 keyNumber : keyNumberVector) {
SharedMemory *sharedMemory = globalSharedMemoryContainer()->take(keyNumber); SharedMemory *sharedMemory = globalSharedMemoryContainer()->take(keyNumber);
delete sharedMemory; delete sharedMemory;
} }

2
share/qtcreator/qml/qmlpuppet/container/imagecontainer.cpp
View File

@@ -79,7 +79,7 @@ void ImageContainer::setImage(const QImage &image)
void ImageContainer::removeSharedMemorys(const QVector<qint32> &keyNumberVector) void ImageContainer::removeSharedMemorys(const QVector<qint32> &keyNumberVector)
{ {
foreach (qint32 keyNumber, keyNumberVector) { for (qint32 keyNumber : keyNumberVector) {
SharedMemory *sharedMemory = globalSharedMemoryContainer()->take(keyNumber); SharedMemory *sharedMemory = globalSharedMemoryContainer()->take(keyNumber);
delete sharedMemory; delete sharedMemory;
} }

3
share/qtcreator/qml/qmlpuppet/instances/nodeinstanceclientproxy.cpp
View File

@@ -303,9 +303,8 @@ void NodeInstanceClientProxy::readDataStream()
break; break;
} }
foreach (const QVariant &command, commandList) { for (const QVariant &command : qAsConst(commandList))
dispatchCommand(command); dispatchCommand(command);
}
} }
void NodeInstanceClientProxy::sendPuppetAliveCommand() void NodeInstanceClientProxy::sendPuppetAliveCommand()

3
share/qtcreator/qml/qmlpuppet/qml2puppet/instances/componentnodeinstance.cpp
View File

@@ -72,7 +72,8 @@ void ComponentNodeInstance::setNodeSource(const QString &source)
setId(id()); setId(id());
if (component()->isError()) { if (component()->isError()) {
foreach (const QQmlError &error, component()->errors()) const QList<QQmlError> errors = component()->errors();
for (const QQmlError &error : errors)
qWarning() << error; qWarning() << error;
} }

2
share/qtcreator/qml/qmlpuppet/qml2puppet/instances/nodeinstanceserver.cpp
View File

@@ -189,7 +189,7 @@ QList<ServerNodeInstance> NodeInstanceServer::createInstances(const QVector<Inst
{ {
Q_ASSERT(declarativeView() || quickView()); Q_ASSERT(declarativeView() || quickView());
QList<ServerNodeInstance> instanceList; QList<ServerNodeInstance> instanceList;
foreach (const InstanceContainer &instanceContainer, containerVector) { for (const InstanceContainer &instanceContainer : containerVector) {
ServerNodeInstance instance; ServerNodeInstance instance;
if (instanceContainer.nodeSourceType() == InstanceContainer::ComponentSource) { if (instanceContainer.nodeSourceType() == InstanceContainer::ComponentSource) {
instance = ServerNodeInstance::create(this, instanceContainer, ServerNodeInstance::WrapAsComponent); instance = ServerNodeInstance::create(this, instanceContainer, ServerNodeInstance::WrapAsComponent);