feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't access static functions/fields via instance

Browse Source 
Courtesy of readability-static-accessed-through-instance

Amends: b2a766a79a

Round #2: This time done with Qt Creator's Analyzer, which
found other occurences than run-clang-tidy.py

Change-Id: I479e280c7abcf2d24baccbb0af69ae4bda05198e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Alessandro Portale
2020-11-27 13:12:23 +01:00
parent 0cc5ee12c5
commit a3857a996a
35 changed files with 52 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/extracompiler.cpp
View File

@@ -290,7 +290,7 @@ void ExtraCompilerPrivate::updateIssues()
cursor.movePosition(QTextCursor::EndOfLine, QTextCursor::KeepAnchor);
selection.cursor = cursor;
const auto fontSettings = TextEditor::TextEditorSettings::instance()->fontSettings();
const auto fontSettings = TextEditor::TextEditorSettings::fontSettings();
selection.format = fontSettings.toTextCharFormat(issue.type == Task::Warning ?
TextEditor::C_WARNING : TextEditor::C_ERROR);
selection.format.setToolTip(issue.description());