feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't access static functions/fields via instance

Browse Source 
Courtesy of readability-static-accessed-through-instance

Amends: b2a766a79a

Round #2: This time done with Qt Creator's Analyzer, which
found other occurences than run-clang-tidy.py

Change-Id: I479e280c7abcf2d24baccbb0af69ae4bda05198e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Alessandro Portale
2020-11-27 13:12:23 +01:00
parent 0cc5ee12c5
commit a3857a996a
35 changed files with 52 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmlprofiler/tests/pixmapcachemodel_test.cpp
View File

@@ -255,10 +255,10 @@ void PixmapCacheModelTest::testConsistency()
break;
}
QString filename = details[model.tr("File")].toString();
QString filename = details[PixmapCacheModel::tr("File")].toString();
QVERIFY(filename == QString("dings.png") || filename == QString("blah.png"));
QVERIFY(details.contains(model.tr("Width")));
QVERIFY(details.contains(model.tr("Height")));
QVERIFY(details.contains(PixmapCacheModel::tr("Width")));
QVERIFY(details.contains(PixmapCacheModel::tr("Height")));
}
}

4
src/plugins/qmlprofiler/tests/qmlprofilerattachdialog_test.cpp
View File

@@ -48,13 +48,13 @@ void QmlProfilerAttachDialogTest::testAccessors()
ProjectExplorer::KitManager *kitManager = ProjectExplorer::KitManager::instance();
QVERIFY(kitManager);
ProjectExplorer::Kit * const newKit = kitManager->registerKit({}, "dings");
ProjectExplorer::Kit * const newKit = ProjectExplorer::KitManager::registerKit({}, "dings");
QVERIFY(newKit);
dialog.setKitId("dings");
QCOMPARE(dialog.kit(), newKit);
kitManager->deregisterKit(newKit);
ProjectExplorer::KitManager::deregisterKit(newKit);
}
} // namespace Internal

2
src/plugins/qmlprofiler/tests/qmlprofilertool_test.cpp
View File

@@ -46,7 +46,7 @@ void QmlProfilerToolTest::testAttachToWaitingApplication()
{
ProjectExplorer::KitManager *kitManager = ProjectExplorer::KitManager::instance();
QVERIFY(kitManager);
ProjectExplorer::Kit * const newKit = kitManager->registerKit({}, "fookit");
ProjectExplorer::Kit * const newKit = ProjectExplorer::KitManager::registerKit({}, "fookit");
QVERIFY(newKit);
QSettings *settings = Core::ICore::settings();
QVERIFY(settings);