From a3c531c2a3ae89161a248a8343c0054fcbeffc5d Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 25 Mar 2022 18:33:06 +0100 Subject: [PATCH] SshRemoteProcessRunner: Get rid of no-op call to QtcProcess::terminate() Calling QtcProcess::terminate() after disconecting from process signals is a task for implicit ProcessReaper. Delete the process instead. Change-Id: I02d9b892125b1a1053aefe8edbc7bc96bac41381 Reviewed-by: hjk --- src/libs/ssh/sshremoteprocessrunner.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/libs/ssh/sshremoteprocessrunner.cpp b/src/libs/ssh/sshremoteprocessrunner.cpp index d0e23b6a4b3..c1259f4d9e1 100644 --- a/src/libs/ssh/sshremoteprocessrunner.cpp +++ b/src/libs/ssh/sshremoteprocessrunner.cpp @@ -158,11 +158,8 @@ void SshRemoteProcessRunner::setState(int newState) d->m_state = static_cast(newState); if (d->m_state == Inactive) { - if (d->m_process) { - disconnect(d->m_process.get(), nullptr, this, nullptr); - d->m_process->terminate(); + if (d->m_process) d->m_process.reset(); - } if (d->m_connection) { disconnect(d->m_connection, nullptr, this, nullptr); SshConnectionManager::releaseConnection(d->m_connection);