diff --git a/src/plugins/android/androiddevice.cpp b/src/plugins/android/androiddevice.cpp index b6bc2a5864d..64e1085d16a 100644 --- a/src/plugins/android/androiddevice.cpp +++ b/src/plugins/android/androiddevice.cpp @@ -78,23 +78,6 @@ IDeviceWidget *AndroidDevice::createWidget() return nullptr; } -QList AndroidDevice::actionIds() const -{ - return QList(); -} - -QString AndroidDevice::displayNameForActionId(Core::Id actionId) const -{ - Q_UNUSED(actionId) - return QString(); -} - -void AndroidDevice::executeAction(Core::Id actionId, QWidget *parent) -{ - Q_UNUSED(actionId) - Q_UNUSED(parent) -} - bool AndroidDevice::canAutoDetectPorts() const { return true; diff --git a/src/plugins/android/androiddevice.h b/src/plugins/android/androiddevice.h index 622e89d6f62..719f479cf2b 100644 --- a/src/plugins/android/androiddevice.h +++ b/src/plugins/android/androiddevice.h @@ -39,9 +39,6 @@ public: QString displayType() const override; ProjectExplorer::IDeviceWidget *createWidget() override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent = nullptr) override; bool canAutoDetectPorts() const override; ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override; Utils::OsType osType() const override; diff --git a/src/plugins/baremetal/baremetaldevice.cpp b/src/plugins/baremetal/baremetaldevice.cpp index 2f50336c79e..e751ec5f837 100644 --- a/src/plugins/baremetal/baremetaldevice.cpp +++ b/src/plugins/baremetal/baremetaldevice.cpp @@ -159,23 +159,6 @@ IDeviceWidget *BareMetalDevice::createWidget() return new BareMetalDeviceConfigurationWidget(sharedFromThis()); } -QList BareMetalDevice::actionIds() const -{ - return QList(); // no actions -} - -QString BareMetalDevice::displayNameForActionId(Core::Id actionId) const -{ - QTC_ASSERT(actionIds().contains(actionId), return QString()); - return QString(); -} - -void BareMetalDevice::executeAction(Core::Id actionId, QWidget *parent) -{ - QTC_ASSERT(actionIds().contains(actionId), return); - Q_UNUSED(parent); -} - Utils::OsType BareMetalDevice::osType() const { return Utils::OsTypeOther; diff --git a/src/plugins/baremetal/baremetaldevice.h b/src/plugins/baremetal/baremetaldevice.h index c608bc8c4e5..2b90ae2ccfc 100644 --- a/src/plugins/baremetal/baremetaldevice.h +++ b/src/plugins/baremetal/baremetaldevice.h @@ -47,9 +47,6 @@ public: ~BareMetalDevice() override; QString displayType() const override; ProjectExplorer::IDeviceWidget *createWidget() override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent) override; Utils::OsType osType() const override; ProjectExplorer::IDevice::Ptr clone() const override; diff --git a/src/plugins/ios/iosdevice.cpp b/src/plugins/ios/iosdevice.cpp index 00aa84182dd..09880f1ce26 100644 --- a/src/plugins/ios/iosdevice.cpp +++ b/src/plugins/ios/iosdevice.cpp @@ -130,23 +130,6 @@ IDeviceWidget *IosDevice::createWidget() return nullptr; } -QList IosDevice::actionIds() const -{ - return QList(); // add activation action? -} - -QString IosDevice::displayNameForActionId(Core::Id actionId) const -{ - Q_UNUSED(actionId) - return QString(); -} - -void IosDevice::executeAction(Core::Id actionId, QWidget *parent) -{ - Q_UNUSED(actionId) - Q_UNUSED(parent) -} - DeviceProcessSignalOperation::Ptr IosDevice::signalOperation() const { return DeviceProcessSignalOperation::Ptr(); diff --git a/src/plugins/ios/iosdevice.h b/src/plugins/ios/iosdevice.h index b0cd7cb9b97..54f5785e70e 100644 --- a/src/plugins/ios/iosdevice.h +++ b/src/plugins/ios/iosdevice.h @@ -54,9 +54,6 @@ public: ProjectExplorer::IDevice::DeviceInfo deviceInformation() const override; ProjectExplorer::IDeviceWidget *createWidget() override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent = nullptr) override; ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override; QString displayType() const override; diff --git a/src/plugins/ios/iossimulator.cpp b/src/plugins/ios/iossimulator.cpp index d78026399f8..df7b46e497a 100644 --- a/src/plugins/ios/iossimulator.cpp +++ b/src/plugins/ios/iossimulator.cpp @@ -89,23 +89,6 @@ IDeviceWidget *IosSimulator::createWidget() return nullptr; } -QList IosSimulator::actionIds() const -{ - return QList(); -} - -QString IosSimulator::displayNameForActionId(Core::Id actionId) const -{ - Q_UNUSED(actionId) - return QString(); -} - -void IosSimulator::executeAction(Core::Id actionId, QWidget *parent) -{ - Q_UNUSED(actionId) - Q_UNUSED(parent) -} - DeviceProcessSignalOperation::Ptr IosSimulator::signalOperation() const { return DeviceProcessSignalOperation::Ptr(); diff --git a/src/plugins/ios/iossimulator.h b/src/plugins/ios/iossimulator.h index e30505d130e..d4652dfe4ba 100644 --- a/src/plugins/ios/iossimulator.h +++ b/src/plugins/ios/iossimulator.h @@ -69,9 +69,6 @@ public: QString displayType() const override; ProjectExplorer::IDeviceWidget *createWidget() override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent = nullptr) override; ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override; void fromMap(const QVariantMap &map) override; QVariantMap toMap() const override; diff --git a/src/plugins/projectexplorer/devicesupport/desktopdevice.cpp b/src/plugins/projectexplorer/devicesupport/desktopdevice.cpp index eef4931904c..dc49149df5a 100644 --- a/src/plugins/projectexplorer/devicesupport/desktopdevice.cpp +++ b/src/plugins/projectexplorer/devicesupport/desktopdevice.cpp @@ -80,23 +80,6 @@ IDeviceWidget *DesktopDevice::createWidget() // range can be confusing to the user. Hence, disabling the widget for now. } -QList DesktopDevice::actionIds() const -{ - return QList(); -} - -QString DesktopDevice::displayNameForActionId(Core::Id actionId) const -{ - Q_UNUSED(actionId); - return QString(); -} - -void DesktopDevice::executeAction(Core::Id actionId, QWidget *parent) -{ - Q_UNUSED(actionId); - Q_UNUSED(parent); -} - bool DesktopDevice::canAutoDetectPorts() const { return true; diff --git a/src/plugins/projectexplorer/devicesupport/desktopdevice.h b/src/plugins/projectexplorer/devicesupport/desktopdevice.h index 5074c2d88bf..da57cf95bdb 100644 --- a/src/plugins/projectexplorer/devicesupport/desktopdevice.h +++ b/src/plugins/projectexplorer/devicesupport/desktopdevice.h @@ -42,9 +42,6 @@ public: QString displayType() const override; IDeviceWidget *createWidget() override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent = nullptr) override; bool canAutoDetectPorts() const override; bool canCreateProcessModel() const override; DeviceProcessList *createProcessListModel(QObject *parent) const override; diff --git a/src/plugins/projectexplorer/devicesupport/devicemanager.cpp b/src/plugins/projectexplorer/devicesupport/devicemanager.cpp index e5bcc779a92..f7cbf083f13 100644 --- a/src/plugins/projectexplorer/devicesupport/devicemanager.cpp +++ b/src/plugins/projectexplorer/devicesupport/devicemanager.cpp @@ -413,9 +413,6 @@ private: TestDevice(const TestDevice &other) = default; QString displayType() const override { return QLatin1String("blubb"); } IDeviceWidget *createWidget() override { return nullptr; } - QList actionIds() const override { return QList(); } - QString displayNameForActionId(Core::Id) const override { return QString(); } - void executeAction(Core::Id, QWidget *) override { } Ptr clone() const override { return Ptr(new TestDevice(*this)); } DeviceProcessSignalOperation::Ptr signalOperation() const override { diff --git a/src/plugins/projectexplorer/devicesupport/devicesettingswidget.cpp b/src/plugins/projectexplorer/devicesupport/devicesettingswidget.cpp index 4cd0f8a490e..5cb6623f1c2 100644 --- a/src/plugins/projectexplorer/devicesupport/devicesettingswidget.cpp +++ b/src/plugins/projectexplorer/devicesupport/devicesettingswidget.cpp @@ -299,11 +299,19 @@ void DeviceSettingsWidget::currentDeviceChanged(int index) m_ui->buttonsLayout->insertWidget(m_ui->buttonsLayout->count() - 1, button); } - foreach (Id actionId, device->actionIds()) { - QPushButton * const button = new QPushButton(device->displayNameForActionId(actionId)); + for (const IDevice::DeviceAction &deviceAction : device->deviceActions()) { + QPushButton * const button = new QPushButton(deviceAction.display); m_additionalActionButtons << button; - connect(button, &QAbstractButton::clicked, this, - [this, actionId] { handleAdditionalActionRequest(actionId); }); + connect(button, &QAbstractButton::clicked, this, [this, deviceAction] { + const IDevice::Ptr device = m_deviceManager->mutableDevice(currentDevice()->id()); + QTC_ASSERT(device, return); + updateDeviceFromUi(); + deviceAction.execute(device, this); + // Widget must be set up from scratch, because the action could have + // changed random attributes. + currentDeviceChanged(currentIndex()); + }); + m_ui->buttonsLayout->insertWidget(m_ui->buttonsLayout->count() - 1, button); } @@ -322,17 +330,6 @@ void DeviceSettingsWidget::clearDetails() m_ui->autoDetectionValueLabel->clear(); } -void DeviceSettingsWidget::handleAdditionalActionRequest(Id actionId) -{ - const IDevice::Ptr device = m_deviceManager->mutableDevice(currentDevice()->id()); - QTC_ASSERT(device, return); - updateDeviceFromUi(); - device->executeAction(actionId, this); - - // Widget must be set up from scratch, because the action could have changed random attributes. - currentDeviceChanged(currentIndex()); -} - void DeviceSettingsWidget::handleProcessListRequested() { QTC_ASSERT(currentDevice()->canCreateProcessModel(), return); diff --git a/src/plugins/projectexplorer/devicesupport/devicesettingswidget.h b/src/plugins/projectexplorer/devicesupport/devicesettingswidget.h index 28662bd4153..a7961e145d1 100644 --- a/src/plugins/projectexplorer/devicesupport/devicesettingswidget.h +++ b/src/plugins/projectexplorer/devicesupport/devicesettingswidget.h @@ -65,7 +65,6 @@ private: void handleProcessListRequested(); void initGui(); - void handleAdditionalActionRequest(Core::Id actionId); void displayCurrent(); void setDeviceInfoWidgetsEnabled(bool enable); IDevice::ConstPtr currentDevice() const; diff --git a/src/plugins/projectexplorer/devicesupport/idevice.cpp b/src/plugins/projectexplorer/devicesupport/idevice.cpp index 4ffb3efc5b7..559ee99803e 100644 --- a/src/plugins/projectexplorer/devicesupport/idevice.cpp +++ b/src/plugins/projectexplorer/devicesupport/idevice.cpp @@ -44,6 +44,15 @@ #include #include +/*! + * \class ProjectExplorer::IDevice::DeviceAction + * \brief The DeviceAction class describes an action that can be run on a device. + * + * The description consists of a human-readable string that will be displayed + * on a button which, when clicked, executes a functor, and the functor itself. + * This is typically some sort of dialog or wizard, so \a parent widget is provided. + */ + /*! * \class ProjectExplorer::IDevice * \brief The IDevice class is the base class for all devices. @@ -76,23 +85,11 @@ */ /*! - * \fn QStringList ProjectExplorer::IDevice::actionIds() const - * Returns a list of ids representing actions that can be run on this device. + * \fn void ProjectExplorer::IDevice::addDeviceAction(const DeviceAction &deviceAction) + * Adds an actions that can be run on this device. * These actions will be available in the \gui Devices options page. */ -/*! - * \fn QString ProjectExplorer::IDevice::displayNameForActionId(Core::Id actionId) const - * A human-readable string for \a actionId. Will be displayed on a button which, - * when clicked, starts the respective action. - */ - -/*! - * \fn void ProjectExplorer::IDevice::executeAction(Core::Id actionId, QWidget *parent) const - * Executes the action specified by \a actionId. This is typically done via some - * sort of dialog or wizard, so \a parent widget is provided. - */ - /*! * \fn ProjectExplorer::IDevice::Ptr ProjectExplorer::IDevice::clone() const * Creates an identical copy of a device object. @@ -153,6 +150,7 @@ public: QString qmlsceneCommand; QList deviceIcons; + QList deviceActions; QVariantMap extraData; }; } // namespace Internal @@ -252,6 +250,16 @@ bool IDevice::isCompatibleWith(const Kit *k) const return DeviceTypeKitInformation::deviceTypeId(k) == type(); } +void IDevice::addDeviceAction(const DeviceAction &deviceAction) +{ + d->deviceActions.append(deviceAction); +} + +const QList IDevice::deviceActions() const +{ + return d->deviceActions; +} + PortsGatheringMethod::Ptr IDevice::portsGatheringMethod() const { return PortsGatheringMethod::Ptr(); diff --git a/src/plugins/projectexplorer/devicesupport/idevice.h b/src/plugins/projectexplorer/devicesupport/idevice.h index f6cfaef5744..eadec6b0348 100644 --- a/src/plugins/projectexplorer/devicesupport/idevice.h +++ b/src/plugins/projectexplorer/devicesupport/idevice.h @@ -153,9 +153,13 @@ public: virtual QString displayType() const = 0; virtual IDeviceWidget *createWidget() = 0; - virtual QList actionIds() const = 0; - virtual QString displayNameForActionId(Core::Id actionId) const = 0; - virtual void executeAction(Core::Id actionId, QWidget *parent = nullptr) = 0; + + struct DeviceAction { + QString display; + std::function execute; + }; + void addDeviceAction(const DeviceAction &deviceAction); + const QList deviceActions() const; // Devices that can auto detect ports need not return a ports gathering method. Such devices can // obtain a free port on demand. eg: Desktop device. diff --git a/src/plugins/qnx/qnxdevice.cpp b/src/plugins/qnx/qnxdevice.cpp index 500ebcd9764..2e586b33afc 100644 --- a/src/plugins/qnx/qnxdevice.cpp +++ b/src/plugins/qnx/qnxdevice.cpp @@ -50,7 +50,6 @@ namespace Qnx { using namespace Internal; const char QnxVersionKey[] = "QnxVersion"; -const char DeployQtLibrariesActionId [] = "Qnx.Qnx.DeployQtLibrariesAction"; class QnxPortsGatheringMethod : public PortsGatheringMethod { @@ -79,19 +78,26 @@ class QnxPortsGatheringMethod : public PortsGatheringMethod }; QnxDevice::QnxDevice() - : RemoteLinux::LinuxDevice() - , m_versionNumber(0) { + init(); } QnxDevice::QnxDevice(const QString &name, Core::Id type, MachineType machineType, Origin origin, Core::Id id) : RemoteLinux::LinuxDevice(name, type, machineType, origin, id) - , m_versionNumber(0) { + init(); } QnxDevice::QnxDevice(const QnxDevice &other) = default; +void QnxDevice::init() +{ + addDeviceAction({tr("Deploy Qt libraries..."), [](const IDevice::Ptr &device, QWidget *parent) { + QnxDeployQtLibrariesDialog dialog(device, parent); + dialog.exec(); + }}); +} + QnxDevice::Ptr QnxDevice::create() { return Ptr(new QnxDevice); @@ -190,33 +196,6 @@ DeviceProcess *QnxDevice::createProcess(QObject *parent) const return new QnxDeviceProcess(sharedFromThis(), parent); } -QList QnxDevice::actionIds() const -{ - QList actions = RemoteLinux::LinuxDevice::actionIds(); - actions << Core::Id(DeployQtLibrariesActionId); - return actions; -} - -QString QnxDevice::displayNameForActionId(Core::Id actionId) const -{ - if (actionId == Core::Id(DeployQtLibrariesActionId)) - return tr("Deploy Qt libraries..."); - - return RemoteLinux::LinuxDevice::displayNameForActionId(actionId); -} - -void QnxDevice::executeAction(Core::Id actionId, QWidget *parent) -{ - const QnxDevice::ConstPtr device = - sharedFromThis().staticCast(); - if (actionId == Core::Id(DeployQtLibrariesActionId)) { - QnxDeployQtLibrariesDialog dialog(device, parent); - dialog.exec(); - } else { - RemoteLinux::LinuxDevice::executeAction(actionId, parent); - } -} - DeviceProcessSignalOperation::Ptr QnxDevice::signalOperation() const { return DeviceProcessSignalOperation::Ptr( diff --git a/src/plugins/qnx/qnxdevice.h b/src/plugins/qnx/qnxdevice.h index 430c05a7e22..16b6030524d 100644 --- a/src/plugins/qnx/qnxdevice.h +++ b/src/plugins/qnx/qnxdevice.h @@ -51,10 +51,6 @@ public: ProjectExplorer::DeviceTester *createDeviceTester() const override; ProjectExplorer::DeviceProcess *createProcess(QObject *parent) const override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent) override; - QString displayType() const override; Utils::OsType osType() const override; @@ -74,8 +70,9 @@ protected: private: void updateVersionNumber() const; + void init(); - mutable int m_versionNumber; + mutable int m_versionNumber = 0; }; } // namespace Qnx diff --git a/src/plugins/remotelinux/linuxdevice.cpp b/src/plugins/remotelinux/linuxdevice.cpp index 83dd01c6d8b..ef483521edc 100644 --- a/src/plugins/remotelinux/linuxdevice.cpp +++ b/src/plugins/remotelinux/linuxdevice.cpp @@ -52,9 +52,6 @@ namespace RemoteLinux { const char Delimiter0[] = "x--"; const char Delimiter1[] = "---"; - -static Core::Id openShellActionId() { return "RemoteLinux.OpenShellAction"; } - static QString visualizeNull(QString s) { return s.replace(QLatin1Char('\0'), QLatin1String("")); @@ -185,60 +182,6 @@ IDeviceWidget *LinuxDevice::createWidget() return new GenericLinuxDeviceConfigurationWidget(sharedFromThis()); } -QList LinuxDevice::actionIds() const -{ - QList ids({Core::Id(Constants::GenericDeployKeyToDeviceActionId)}); - if (Utils::HostOsInfo::isAnyUnixHost()) - ids << openShellActionId(); - return ids; -} - -QString LinuxDevice::displayNameForActionId(Core::Id actionId) const -{ - QTC_ASSERT(actionIds().contains(actionId), return QString()); - - if (actionId == Constants::GenericDeployKeyToDeviceActionId) - return tr("Deploy Public Key..."); - if (actionId == openShellActionId()) - return tr("Open Remote Shell"); - return QString(); // Can't happen. -} - -void LinuxDevice::executeAction(Core::Id actionId, QWidget *parent) -{ - QTC_ASSERT(actionIds().contains(actionId), return); - - if (actionId == Constants::GenericDeployKeyToDeviceActionId) { - const LinuxDevice::ConstPtr device = sharedFromThis().staticCast(); - QDialog * const d = PublicKeyDeploymentDialog::createDialog(device, parent); - if (d) - d->exec(); - delete d; - return; - } - if (actionId == openShellActionId()) { - DeviceProcess * const proc = createProcess(nullptr); - QObject::connect(proc, &DeviceProcess::finished, [proc] { - if (!proc->errorString().isEmpty()) { - Core::MessageManager::write(tr("Error running remote shell: %1") - .arg(proc->errorString()), - Core::MessageManager::ModeSwitch); - } - proc->deleteLater(); - }); - QObject::connect(proc, &DeviceProcess::error, [proc] { - Core::MessageManager::write(tr("Error starting remote shell."), - Core::MessageManager::ModeSwitch); - proc->deleteLater(); - }); - Runnable runnable; - runnable.device = sharedFromThis().staticCast(); - proc->setRunInTerminal(true); - proc->start(runnable); - return; - } -} - Utils::OsType LinuxDevice::osType() const { return Utils::OsTypeLinux; @@ -249,10 +192,44 @@ LinuxDevice::LinuxDevice(const QString &name, Core::Id type, MachineType machine : IDevice(type, origin, machineType, id) { setDisplayName(name); + init(); } LinuxDevice::LinuxDevice(const LinuxDevice &other) = default; +void LinuxDevice::init() +{ + addDeviceAction({tr("Deploy Public Key..."), [](const IDevice::Ptr &device, QWidget *parent) { + if (auto d = PublicKeyDeploymentDialog::createDialog(device, parent)) { + d->exec(); + delete d; + } + }}); + + if (Utils::HostOsInfo::isAnyUnixHost()) { + addDeviceAction({tr("Open Remote Shell"), [](const IDevice::Ptr &device, QWidget *) { + DeviceProcess * const proc = device->createProcess(nullptr); + QObject::connect(proc, &DeviceProcess::finished, [proc] { + if (!proc->errorString().isEmpty()) { + Core::MessageManager::write(tr("Error running remote shell: %1") + .arg(proc->errorString()), + Core::MessageManager::ModeSwitch); + } + proc->deleteLater(); + }); + QObject::connect(proc, &DeviceProcess::error, [proc] { + Core::MessageManager::write(tr("Error starting remote shell."), + Core::MessageManager::ModeSwitch); + proc->deleteLater(); + }); + Runnable runnable; + runnable.device = device; + proc->setRunInTerminal(true); + proc->start(runnable); + }}); + } +} + LinuxDevice::Ptr LinuxDevice::create() { return Ptr(new LinuxDevice); diff --git a/src/plugins/remotelinux/linuxdevice.h b/src/plugins/remotelinux/linuxdevice.h index 919ccb092e0..3ddf8294a8f 100644 --- a/src/plugins/remotelinux/linuxdevice.h +++ b/src/plugins/remotelinux/linuxdevice.h @@ -48,9 +48,6 @@ public: QString displayType() const override; ProjectExplorer::IDeviceWidget *createWidget() override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent) override; Utils::OsType osType() const override; ProjectExplorer::IDevice::Ptr clone() const override; @@ -69,13 +66,14 @@ public: bool supportsRSync() const; protected: - LinuxDevice() = default; + LinuxDevice() { init(); } LinuxDevice(const QString &name, Core::Id type, MachineType machineType, Origin origin, Core::Id id); LinuxDevice(const LinuxDevice &other); private: LinuxDevice &operator=(const LinuxDevice &); + void init(); }; } // namespace RemoteLinux diff --git a/src/plugins/remotelinux/remotelinux_constants.h b/src/plugins/remotelinux/remotelinux_constants.h index 43bd85fe879..1b34d1d4d73 100644 --- a/src/plugins/remotelinux/remotelinux_constants.h +++ b/src/plugins/remotelinux/remotelinux_constants.h @@ -30,8 +30,6 @@ namespace Constants { const char GenericLinuxOsType[] = "GenericLinuxOsType"; -const char GenericDeployKeyToDeviceActionId[] = "RemoteLinux.GenericDeployKeyToDeviceAction"; - const char EMBEDDED_LINUX_QT[] = "RemoteLinux.EmbeddedLinuxQt"; } // Constants diff --git a/src/plugins/winrt/winrtdevice.cpp b/src/plugins/winrt/winrtdevice.cpp index eeb0927d814..93c471634a4 100644 --- a/src/plugins/winrt/winrtdevice.cpp +++ b/src/plugins/winrt/winrtdevice.cpp @@ -77,23 +77,6 @@ IDeviceWidget *WinRtDevice::createWidget() return nullptr; } -QList WinRtDevice::actionIds() const -{ - return QList(); -} - -QString WinRtDevice::displayNameForActionId(Core::Id actionId) const -{ - Q_UNUSED(actionId); - return QString(); -} - -void WinRtDevice::executeAction(Core::Id actionId, QWidget *parent) -{ - Q_UNUSED(actionId); - Q_UNUSED(parent); -} - DeviceProcessSignalOperation::Ptr WinRtDevice::signalOperation() const { class WinRtDesktopSignalOperation : public DesktopProcessSignalOperation diff --git a/src/plugins/winrt/winrtdevice.h b/src/plugins/winrt/winrtdevice.h index 32548b219cb..72fc050cda9 100644 --- a/src/plugins/winrt/winrtdevice.h +++ b/src/plugins/winrt/winrtdevice.h @@ -39,9 +39,6 @@ public: QString displayType() const override; ProjectExplorer::IDeviceWidget *createWidget() override; - QList actionIds() const override; - QString displayNameForActionId(Core::Id actionId) const override; - void executeAction(Core::Id actionId, QWidget *parent) override; ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override; void fromMap(const QVariantMap &map) override; QVariantMap toMap() const override;