From a4215384146e305095083c799ab0e287bf9e8613 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Thu, 20 Aug 2015 16:06:53 -0700 Subject: [PATCH] Fix bad use of port numbers. -1 is not a valid quint16 number. It gets converted to 65535, which is a valid port number. So, instead, use port number 0 which isn't valid (if you try to bind to it, the OS chooses a port for you). Found by ICC src/plugins/android/androidrunner.cpp(150): warning #68: integer conversion resulted in a change of sign Change-Id: I7de033f80b0e4431b7f1ffff13fc4e4f0f7af445 Reviewed-by: BogDan Vatra --- src/plugins/android/androidrunner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/android/androidrunner.cpp b/src/plugins/android/androidrunner.cpp index c530d008cfb..59d3be60d24 100644 --- a/src/plugins/android/androidrunner.cpp +++ b/src/plugins/android/androidrunner.cpp @@ -147,7 +147,7 @@ AndroidRunner::AndroidRunner(QObject *parent, qDebug() << tr("No free ports available on host for QML debugging.")); m_qmlPort = server.serverPort(); } else { - m_qmlPort = -1; + m_qmlPort = 0; } ProjectExplorer::Target *target = runConfig->target(); m_useLocalQtLibs = AndroidManager::useLocalLibs(target);