forked from qt-creator/qt-creator
ProjectExplorer: Remove ToolChain::canClone()
Was returning true in all cases. Change-Id: Iafbafbf44a0b631b83e768c75f963e1bb7821a25 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
This commit is contained in:
@@ -1000,11 +1000,6 @@ std::unique_ptr<ToolChainConfigWidget> MsvcToolChain::createConfigurationWidget(
|
|||||||
return std::make_unique<MsvcToolChainConfigWidget>(this);
|
return std::make_unique<MsvcToolChainConfigWidget>(this);
|
||||||
}
|
}
|
||||||
|
|
||||||
bool MsvcToolChain::canClone() const
|
|
||||||
{
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
ToolChain *MsvcToolChain::clone() const
|
ToolChain *MsvcToolChain::clone() const
|
||||||
{
|
{
|
||||||
return new MsvcToolChain(*this);
|
return new MsvcToolChain(*this);
|
||||||
|
@@ -79,7 +79,6 @@ public:
|
|||||||
|
|
||||||
std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() override;
|
std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() override;
|
||||||
|
|
||||||
bool canClone() const override;
|
|
||||||
ToolChain *clone() const override;
|
ToolChain *clone() const override;
|
||||||
|
|
||||||
MacroInspectionRunner createMacroInspectionRunner() const override;
|
MacroInspectionRunner createMacroInspectionRunner() const override;
|
||||||
|
@@ -197,11 +197,6 @@ Core::Id ToolChain::language() const
|
|||||||
return d->m_language;
|
return d->m_language;
|
||||||
}
|
}
|
||||||
|
|
||||||
bool ToolChain::canClone() const
|
|
||||||
{
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
bool ToolChain::operator == (const ToolChain &tc) const
|
bool ToolChain::operator == (const ToolChain &tc) const
|
||||||
{
|
{
|
||||||
if (this == &tc)
|
if (this == &tc)
|
||||||
|
@@ -146,7 +146,6 @@ public:
|
|||||||
virtual bool operator ==(const ToolChain &) const;
|
virtual bool operator ==(const ToolChain &) const;
|
||||||
|
|
||||||
virtual std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() = 0;
|
virtual std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() = 0;
|
||||||
virtual bool canClone() const;
|
|
||||||
virtual ToolChain *clone() const = 0;
|
virtual ToolChain *clone() const = 0;
|
||||||
|
|
||||||
// Used by the toolchainmanager to save user-generated tool chains.
|
// Used by the toolchainmanager to save user-generated tool chains.
|
||||||
|
@@ -543,7 +543,7 @@ void ToolChainOptionsWidget::updateState()
|
|||||||
bool canDelete = false;
|
bool canDelete = false;
|
||||||
if (ToolChainTreeItem *item = currentTreeItem()) {
|
if (ToolChainTreeItem *item = currentTreeItem()) {
|
||||||
ToolChain *tc = item->toolChain;
|
ToolChain *tc = item->toolChain;
|
||||||
canCopy = tc->isValid() && tc->canClone();
|
canCopy = tc->isValid();
|
||||||
canDelete = tc->detection() != ToolChain::AutoDetection;
|
canDelete = tc->detection() != ToolChain::AutoDetection;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user