feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use QFileInfo::exist(f) instead of QFileInfo(f).exists() if possible

Browse Source 
Faster.

Change-Id: I91aa67462e11ff3258600d7f158de79942d0dc81
Reviewed-by: Marc Reilly <marc.reilly@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
This commit is contained in:
hjk
2014-10-24 10:28:28 +02:00
parent 1e9b561cae
commit a439483d70
53 changed files with 77 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/qnx/qnxutils.cpp
View File

@@ -93,7 +93,7 @@ QList<Utils::EnvironmentItem> QnxUtils::qnxEnvironmentFromEnvFile(const QString
{
QList <Utils::EnvironmentItem> items;
if (!QFileInfo(fileName).exists())
if (!QFileInfo::exists(fileName))
return items;
const bool isWindows = Utils::HostOsInfo::isWindowsHost();
@@ -157,7 +157,7 @@ QList<Utils::EnvironmentItem> QnxUtils::qnxEnvironmentFromEnvFile(const QString
bool QnxUtils::isValidNdkPath(const QString &ndkPath)
{
return (QFileInfo(envFilePath(ndkPath)).exists());
return QFileInfo::exists(envFilePath(ndkPath));
}
QString QnxUtils::envFilePath(const QString &ndkPath, const QString &targetVersion)
@@ -168,7 +168,7 @@ QString QnxUtils::envFilePath(const QString &ndkPath, const QString &targetVersi
else if (Utils::HostOsInfo::isAnyUnixHost())
envFile = ndkPath + QLatin1String("/bbndk-env.sh");
if (!QFileInfo(envFile).exists()) {
if (!QFileInfo::exists(envFile)) {
QString version = targetVersion.isEmpty() ? defaultTargetVersion(ndkPath) : targetVersion;
version = version.replace(QLatin1Char('.'), QLatin1Char('_'));
if (Utils::HostOsInfo::isWindowsHost())
@@ -268,7 +268,7 @@ QString QnxUtils::sdkInstallerPath(const QString &ndkPath)
{
QString sdkinstallPath = Utils::HostOsInfo::withExecutableSuffix(ndkPath + QLatin1String("/qde"));
if (QFileInfo(sdkinstallPath).exists())
if (QFileInfo::exists(sdkinstallPath))
return sdkinstallPath;
return QString();