forked from qt-creator/qt-creator
Provide an empty default IPlugin::extensionsInitialized()
And remove all empy re-implementations. Change-Id: I19f0b4e55c042c96693ecb89766f97f0a97b54ae Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
@@ -54,7 +54,7 @@ public:
|
||||
~IPlugin() override;
|
||||
|
||||
virtual bool initialize(const QStringList &arguments, QString *errorString) = 0;
|
||||
virtual void extensionsInitialized() = 0;
|
||||
virtual void extensionsInitialized() {}
|
||||
virtual bool delayedInitialize() { return false; }
|
||||
virtual ShutdownFlag aboutToShutdown() { return SynchronousShutdown; }
|
||||
virtual QObject *remoteCommand(const QStringList & /* options */,
|
||||
|
@@ -38,7 +38,6 @@ class AndroidPlugin final : public ExtensionSystem::IPlugin
|
||||
~AndroidPlugin() final;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final { }
|
||||
|
||||
void kitsRestored();
|
||||
|
||||
|
@@ -38,7 +38,6 @@ class BookmarksPlugin final : public ExtensionSystem::IPlugin
|
||||
~BookmarksPlugin() final;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
class BookmarksPluginPrivate *d = nullptr;
|
||||
};
|
||||
|
@@ -184,10 +184,6 @@ void ClangCodeModelPlugin::createCompilationDBButton()
|
||||
});
|
||||
}
|
||||
|
||||
void ClangCodeModelPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
// For e.g. creation of profile-guided optimization builds.
|
||||
void ClangCodeModelPlugin::maybeHandleBatchFileAndExit() const
|
||||
{
|
||||
|
@@ -45,7 +45,6 @@ class ClangCodeModelPlugin final: public ExtensionSystem::IPlugin
|
||||
public:
|
||||
~ClangCodeModelPlugin() override;
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) override;
|
||||
void extensionsInitialized() override;
|
||||
|
||||
private:
|
||||
void maybeHandleBatchFileAndExit() const;
|
||||
|
@@ -35,7 +35,6 @@ class ClangFormatPlugin : public ExtensionSystem::IPlugin
|
||||
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "ClangFormat.json")
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final {}
|
||||
};
|
||||
|
||||
} // namespace ClangTools
|
||||
|
@@ -136,10 +136,6 @@ bool ClangPchManagerPlugin::initialize(const QStringList & /*arguments*/, QStrin
|
||||
return true;
|
||||
}
|
||||
|
||||
void ClangPchManagerPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
ExtensionSystem::IPlugin::ShutdownFlag ClangPchManagerPlugin::aboutToShutdown()
|
||||
{
|
||||
d->connectionClient.finishProcess();
|
||||
|
@@ -47,7 +47,6 @@ public:
|
||||
~ClangPchManagerPlugin();
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage);
|
||||
void extensionsInitialized();
|
||||
ShutdownFlag aboutToShutdown();
|
||||
|
||||
static PchManagerClient &pchManagerClient();
|
||||
|
@@ -131,10 +131,6 @@ bool ClangRefactoringPlugin::initialize(const QStringList & /*arguments*/, QStri
|
||||
return true;
|
||||
}
|
||||
|
||||
void ClangRefactoringPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
ExtensionSystem::IPlugin::ShutdownFlag ClangRefactoringPlugin::aboutToShutdown()
|
||||
{
|
||||
CppTools::CppModelManager::removeRefactoringEngine(
|
||||
|
@@ -50,7 +50,6 @@ public:
|
||||
ClangRefactoringPlugin();
|
||||
~ClangRefactoringPlugin();
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage);
|
||||
void extensionsInitialized();
|
||||
ShutdownFlag aboutToShutdown();
|
||||
|
||||
static RefactoringEngine &refactoringEngine();
|
||||
|
@@ -45,7 +45,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final {}
|
||||
QVector<QObject *> createTestObjects() const final;
|
||||
|
||||
class ClangToolsPluginPrivate *d = nullptr;
|
||||
|
@@ -38,7 +38,6 @@ class CompilationDatabaseProjectManagerPlugin final : public ExtensionSystem::IP
|
||||
~CompilationDatabaseProjectManagerPlugin();
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
QVector<QObject *> createTestObjects() const final;
|
||||
|
||||
class CompilationDatabaseProjectManagerPluginPrivate *d = nullptr;
|
||||
|
@@ -66,7 +66,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
ShutdownFlag aboutToShutdown() final;
|
||||
|
||||
CodePasterPluginPrivate *d = nullptr;
|
||||
|
@@ -45,7 +45,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
std::unique_ptr<CppcheckPluginPrivate> d;
|
||||
};
|
||||
|
@@ -50,9 +50,5 @@ bool CtfVisualizerPlugin::initialize(const QStringList &arguments, QString *erro
|
||||
return true;
|
||||
}
|
||||
|
||||
void CtfVisualizerPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
} // namespace Internal
|
||||
} // namespace CtfVisualizer
|
||||
|
@@ -40,7 +40,6 @@ public:
|
||||
~CtfVisualizerPlugin();
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final;
|
||||
|
||||
class CtfVisualizerPluginPrivate *d = nullptr;
|
||||
};
|
||||
|
@@ -54,7 +54,6 @@ public:
|
||||
~DiffEditorPlugin() final;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {};
|
||||
|
||||
private:
|
||||
class DiffEditorPluginPrivate *d = nullptr;
|
||||
|
@@ -42,7 +42,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
class ImageViewerPluginPrivate *d = nullptr;
|
||||
};
|
||||
|
@@ -41,7 +41,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
class IosPluginPrivate *d = nullptr;
|
||||
};
|
||||
|
@@ -39,7 +39,6 @@ public:
|
||||
~MacrosPlugin() final;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
private:
|
||||
class MacrosPluginPrivate *d = nullptr;
|
||||
|
@@ -40,7 +40,6 @@ public:
|
||||
MarketplacePlugin() = default;
|
||||
|
||||
bool initialize(const QStringList &, QString *) final { return true; }
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
private:
|
||||
Internal::QtMarketplaceWelcomePage welcomePage;
|
||||
|
@@ -91,10 +91,6 @@ bool PerfProfilerPlugin::initialize(const QStringList &arguments, QString *error
|
||||
return true;
|
||||
}
|
||||
|
||||
void PerfProfilerPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
PerfSettings *PerfProfilerPlugin::globalSettings()
|
||||
{
|
||||
return perfGlobalSettings();
|
||||
|
@@ -41,7 +41,6 @@ public:
|
||||
~PerfProfilerPlugin();
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final;
|
||||
QVector<QObject *> createTestObjects() const final;
|
||||
|
||||
static PerfSettings *globalSettings();
|
||||
|
@@ -263,9 +263,6 @@ bool QbsProjectManagerPlugin::initialize(const QStringList &arguments, QString *
|
||||
return true;
|
||||
}
|
||||
|
||||
void QbsProjectManagerPlugin::extensionsInitialized()
|
||||
{ }
|
||||
|
||||
void QbsProjectManagerPlugin::targetWasAdded(Target *target)
|
||||
{
|
||||
if (!qobject_cast<QbsProject *>(target->project()))
|
||||
|
@@ -49,7 +49,6 @@ private:
|
||||
~QbsProjectManagerPlugin() final;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final;
|
||||
|
||||
void targetWasAdded(ProjectExplorer::Target *target);
|
||||
void projectChanged();
|
||||
|
@@ -48,7 +48,6 @@ private slots:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
class QmakeProjectManagerPluginPrivate *d = nullptr;
|
||||
};
|
||||
|
@@ -243,10 +243,6 @@ bool QmlPreviewPlugin::initialize(const QStringList &arguments, QString *errorSt
|
||||
return true;
|
||||
}
|
||||
|
||||
void QmlPreviewPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
ExtensionSystem::IPlugin::ShutdownFlag QmlPreviewPlugin::aboutToShutdown()
|
||||
{
|
||||
d->m_parseThread.quit();
|
||||
|
@@ -64,7 +64,6 @@ public:
|
||||
~QmlPreviewPlugin() override;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) override;
|
||||
void extensionsInitialized() override;
|
||||
ShutdownFlag aboutToShutdown() override;
|
||||
QVector<QObject *> createTestObjects() const override;
|
||||
|
||||
|
@@ -41,7 +41,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
class QmlProjectPluginPrivate *d = nullptr;
|
||||
};
|
||||
|
@@ -41,7 +41,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
};
|
||||
|
||||
} // namespace Internal
|
||||
|
@@ -50,10 +50,6 @@ bool SerialTerminalPlugin::initialize(const QStringList &arguments, QString *err
|
||||
return true;
|
||||
}
|
||||
|
||||
void SerialTerminalPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
ExtensionSystem::IPlugin::ShutdownFlag SerialTerminalPlugin::aboutToShutdown()
|
||||
{
|
||||
m_serialOutputPane->closeTabs(SerialOutputPane::CloseTabNoPrompt);
|
||||
|
@@ -44,7 +44,6 @@ public:
|
||||
explicit SerialTerminalPlugin() = default;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final;
|
||||
ShutdownFlag aboutToShutdown() final;
|
||||
|
||||
private:
|
||||
|
@@ -40,10 +40,6 @@ bool SilverSearcherPlugin::initialize(const QStringList &arguments, QString *err
|
||||
return true;
|
||||
}
|
||||
|
||||
void SilverSearcherPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
#ifdef WITH_TESTS
|
||||
QVector<QObject *> SilverSearcherPlugin::createTestObjects() const
|
||||
{
|
||||
|
@@ -37,7 +37,7 @@ class SilverSearcherPlugin : public ExtensionSystem::IPlugin
|
||||
|
||||
public:
|
||||
bool initialize(const QStringList &arguments, QString *errorString) override;
|
||||
void extensionsInitialized() override;
|
||||
|
||||
#ifdef WITH_TESTS
|
||||
private:
|
||||
QVector<QObject *> createTestObjects() const override;
|
||||
|
@@ -43,7 +43,6 @@ public:
|
||||
~TaskListPlugin() final;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) override;
|
||||
void extensionsInitialized() override {}
|
||||
|
||||
static bool loadFile(QString *errorString, const Utils::FilePath &fileName);
|
||||
|
||||
|
@@ -79,10 +79,6 @@ bool TodoPlugin::initialize(const QStringList& args, QString *errMsg)
|
||||
return true;
|
||||
}
|
||||
|
||||
void TodoPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
void TodoPlugin::settingsChanged(const Settings &settings)
|
||||
{
|
||||
settings.save(Core::ICore::settings());
|
||||
|
@@ -47,7 +47,6 @@ public:
|
||||
TodoPlugin();
|
||||
~TodoPlugin() override;
|
||||
|
||||
void extensionsInitialized() override;
|
||||
bool initialize(const QStringList &arguments, QString *errorString) override;
|
||||
|
||||
private:
|
||||
|
@@ -42,7 +42,6 @@ public:
|
||||
~ValgrindPlugin() final;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
private:
|
||||
QVector<QObject *> createTestObjects() const override;
|
||||
|
@@ -135,10 +135,6 @@ bool VcsPlugin::initialize(const QStringList &arguments, QString *errorMessage)
|
||||
return true;
|
||||
}
|
||||
|
||||
void VcsPlugin::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
VcsPlugin *VcsPlugin::instance()
|
||||
{
|
||||
return m_instance;
|
||||
|
@@ -50,8 +50,6 @@ public:
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) override;
|
||||
|
||||
void extensionsInitialized() override;
|
||||
|
||||
static VcsPlugin *instance();
|
||||
|
||||
CommonVcsSettings settings() const;
|
||||
|
@@ -40,7 +40,6 @@ public:
|
||||
|
||||
private:
|
||||
bool initialize(const QStringList &arguments, QString *errorMessage) final;
|
||||
void extensionsInitialized() final {}
|
||||
|
||||
class WinRtPluginPrivate *d = nullptr;
|
||||
};
|
||||
|
@@ -33,8 +33,3 @@ bool MyPlugin1::initialize(const QStringList &arguments, QString *errorString)
|
||||
Q_UNUSED(errorString)
|
||||
return true;
|
||||
}
|
||||
|
||||
void MyPlugin1::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
|
@@ -44,7 +44,6 @@ public:
|
||||
MyPlugin1() = default;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final;
|
||||
};
|
||||
|
||||
} // namespace Plugin1
|
||||
|
@@ -31,8 +31,3 @@ bool MyPlugin2::initialize(const QStringList &, QString *)
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
void MyPlugin2::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
|
@@ -44,7 +44,6 @@ public:
|
||||
MyPlugin2() = default;
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString) final;
|
||||
void extensionsInitialized() final;
|
||||
};
|
||||
|
||||
} // Plugin2
|
||||
|
@@ -38,7 +38,3 @@ bool MyPlugin3::initialize(const QStringList &, QString *)
|
||||
return true;
|
||||
}
|
||||
|
||||
void MyPlugin3::extensionsInitialized()
|
||||
{
|
||||
}
|
||||
|
||||
|
@@ -47,7 +47,6 @@ public:
|
||||
MyPlugin3();
|
||||
|
||||
bool initialize(const QStringList &arguments, QString *errorString);
|
||||
void extensionsInitialized();
|
||||
};
|
||||
|
||||
} // namespace Plugin3
|
||||
|
Reference in New Issue
Block a user