feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ShellCommand: Rename some signals

Browse Source 
Rename the signals used to report stdout/stderr to make it clearer
what they actually do. Remove some unimplemented private member
functions while at it.

Change-Id: I7e856f906ccb45964f3b1b64336d4d8ebca7b9ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Tobias Hunger
2015-04-29 12:50:12 +02:00
parent bba6515562
commit a44c403b5f
6 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libs/utils/shellcommand.cpp
View File

@@ -289,9 +289,9 @@ void ShellCommand::run(QFutureInterface<void> &future)
if (!d->m_aborted) {
if (!d->m_progressiveOutput) {
emit output(stdOut);
emit stdOutText(stdOut);
if (!stdErr.isEmpty())
emit errorText(stdErr);
emit stdErrText(stdErr);
}
emit finished(d->m_lastExecSuccess, d->m_lastExecExitCode, cookie());
@@ -350,7 +350,7 @@ Utils::SynchronousProcessResponse ShellCommand::runCommand(const Utils::FileName
if (!(d->m_flags & SuppressStdErr))
proxy->appendError(text);
if (d->m_progressiveOutput)
emit errorText(text);
emit stdErrText(text);
});
}
@@ -366,7 +366,7 @@ Utils::SynchronousProcessResponse ShellCommand::runCommand(const Utils::FileName
if (d->m_flags & ShowStdOut)
proxy->append(text);
if (d->m_progressiveOutput) {
emit output(text);
emit stdOutText(text);
d->m_hadOutput = true;
}
});