feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Show full description on tooltip in commit chooser dialogs

Browse Source 
Like Push to Gerrit, Rebase, Reset, Fixup Commit.

Fixes: QTCREATORBUG-24366
Change-Id: I0f596f84661a1a4f37fe971683cc0d985a6c9b1f
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Orgad Shaneh
2020-07-31 07:55:08 +03:00
committed by Orgad Shaneh
parent 78406916a3
commit a48cde86f3
5 changed files with 45 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/plugins/git/logchangedialog.cpp
View File

@@ -40,6 +40,7 @@
#include <QVBoxLayout>
#include <QComboBox>
#include <QPainter>
#include <QModelIndex>
using namespace VcsBase;
@@ -53,9 +54,36 @@ enum Columns
ColumnCount
};
class LogChangeModel : public QStandardItemModel
{
public:
explicit LogChangeModel(LogChangeWidget *parent) : QStandardItemModel(0, ColumnCount, parent) {}
QVariant data(const QModelIndex &index, int role) const override
{
if (role == Qt::ToolTipRole) {
const QString revision = index.sibling(index.row(), Sha1Column).data(Qt::EditRole).toString();
const auto it = m_descriptions.constFind(revision);
if (it != m_descriptions.constEnd())
return *it;
const QString desc = QString::fromUtf8(
GitClient::instance()->synchronousShow(
m_workingDirectory, revision, VcsCommand::NoOutput));
m_descriptions[revision] = desc;
return desc;
}
return QStandardItemModel::data(index, role);
}
void setWorkingDirectory(const QString &workingDir) { m_workingDirectory = workingDir; }
private:
QString m_workingDirectory;
mutable QHash<QString, QString> m_descriptions;
};
LogChangeWidget::LogChangeWidget(QWidget *parent)
: Utils::TreeView(parent)
, m_model(new QStandardItemModel(0, ColumnCount, this))
, m_model(new LogChangeModel(this))
, m_hasCustomDelegate(false)
{
QStringList headers;
@@ -72,6 +100,7 @@ LogChangeWidget::LogChangeWidget(QWidget *parent)
bool LogChangeWidget::init(const QString &repository, const QString &commit, LogFlags flags)
{
m_model->setWorkingDirectory(repository);
if (!populateLog(repository, commit, flags))
return false;
if (m_model->rowCount() > 0)