From a503c00fd4a1c2c35ba87176bdc1be05e2f8fa44 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Fri, 28 Jun 2019 11:08:55 +0200
Subject: [PATCH] ProjectExplorer: Do not emit notifications from
 Kit::copyFrom()

This function is a building block for other operations. Emitting a
signal from it will likely provide subscribers with invalid state.

Fixes: QTCREATORBUG-22628
Change-Id: I975638dfa3b453a54c747186b0f6b834c02be035
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
---
 src/plugins/projectexplorer/kit.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/plugins/projectexplorer/kit.cpp b/src/plugins/projectexplorer/kit.cpp
index 88e2e65adaa..bb44b6bec81 100644
--- a/src/plugins/projectexplorer/kit.cpp
+++ b/src/plugins/projectexplorer/kit.cpp
@@ -228,13 +228,11 @@ Kit *Kit::clone(bool keepName) const
 
 void Kit::copyFrom(const Kit *k)
 {
-    KitGuard g(this);
     copyKitCommon(this, k);
     d->m_autodetected = k->d->m_autodetected;
     d->m_autoDetectionSource = k->d->m_autoDetectionSource;
     d->m_unexpandedDisplayName = k->d->m_unexpandedDisplayName;
     d->m_fileSystemFriendlyName = k->d->m_fileSystemFriendlyName;
-    d->m_mustNotify = true;
 }
 
 bool Kit::isValid() const