From a562958b2b91a88332084d52b326f88ad8bcc93b Mon Sep 17 00:00:00 2001 From: Ali Kianian Date: Tue, 22 Apr 2025 16:01:33 +0300 Subject: [PATCH] QmlDesigner: Fix property view dock widget name * A typo has been fixed for the name of property editor dockWidget * This patch also uses the view manager to emit custom notification because in some cases the node is valid, but the view is not available and this causes a crash. Fixes: QDS-15227 Fixes: QDS-15230 Change-Id: Ib9b934bec60e274be5f838d1b96f90a4fcd0ade5 Reviewed-by: Miikka Heikkinen --- .../qmldesigner/components/componentcore/utils3d.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmldesigner/components/componentcore/utils3d.cpp b/src/plugins/qmldesigner/components/componentcore/utils3d.cpp index 11e3a9a4e21..20c6db8468a 100644 --- a/src/plugins/qmldesigner/components/componentcore/utils3d.cpp +++ b/src/plugins/qmldesigner/components/componentcore/utils3d.cpp @@ -561,9 +561,11 @@ void duplicateMaterial(AbstractView *view, const ModelNode &material) void openNodeInPropertyEditor(const ModelNode &node) { + using namespace Qt::StringLiterals; QTC_ASSERT(node, return); - QmlDesignerPlugin::instance()->mainWidget()->showDockWidget("PropertyEditor", true); - node.view()->emitCustomNotification("force_editing_node", {node}); // To PropertyEditor + const auto mainWidget = QmlDesignerPlugin::instance()->mainWidget(); + mainWidget->showDockWidget("Properties"_L1); + mainWidget->viewManager().emitCustomNotification("force_editing_node", {node}, {}); } bool hasImported3dType(AbstractView *view,