Add an option "Stop before build" for windows users

On windows, users frequently get compile errors because the application
binaries/libraries are locked while the application is still running.

A good solution would require actually knowing which builds output files
that are used by the currently running applications, and would
distinguish
between locally running applications and remote applications.

This solution in this patch is far simpler, it offers a option to
stop all runcontrols or stop all runcontrols from the project, that the
user
wants to build. Those options don't take into account whether stopping
those applications is actually needed and is global.

Change-Id: I75b0b6c450898bb29c1e4f9c18c3199aeed696fe
Task-number: QTCREATORBUG-13188
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Daniel Teske
2015-09-17 15:24:32 +02:00
parent cd92b3cd1a
commit a5952658b2
12 changed files with 285 additions and 5 deletions

View File

@@ -0,0 +1,93 @@
/****************************************************************************
**
** Copyright (C) 2015 The Qt Company Ltd.
** Contact: http://www.qt.io/licensing
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms and
** conditions see http://www.qt.io/terms-conditions. For further information
** use the contact form at http://www.qt.io/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 or version 3 as published by the Free
** Software Foundation and appearing in the file LICENSE.LGPLv21 and
** LICENSE.LGPLv3 included in the packaging of this file. Please review the
** following information to ensure the GNU Lesser General Public License
** requirements will be met: https://www.gnu.org/licenses/lgpl.html and
** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, The Qt Company gives you certain additional
** rights. These rights are described in The Qt Company LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
****************************************************************************/
#include "waitforstopdialog.h"
#include <utils/algorithm.h>
#include <QVBoxLayout>
#include <QTimer>
#include <QLabel>
#include <QPushButton>
using namespace ProjectExplorer;
using namespace ProjectExplorer::Internal;
WaitForStopDialog::WaitForStopDialog(QList<ProjectExplorer::RunControl *> runControls)
: m_runControls(runControls)
{
setWindowTitle(tr("Waiting for Applications to Stop"));
QVBoxLayout *layout = new QVBoxLayout();
setLayout(layout);
m_progressLabel = new QLabel;
layout->addWidget(m_progressLabel);
QPushButton *cancelButton = new QPushButton(tr("Cancel"));
connect(cancelButton, &QPushButton::clicked,
this, &QDialog::close);
layout->addWidget(cancelButton);
updateProgressText();
foreach (RunControl *rc, runControls)
connect(rc, &RunControl::finished, this, &WaitForStopDialog::runControlFinished);
m_timer.start();
}
bool WaitForStopDialog::canceled()
{
return !m_runControls.isEmpty();
}
void WaitForStopDialog::updateProgressText()
{
QString text = tr("Waiting for applications to stop.") + QLatin1String("\n\n");
QStringList names = Utils::transform(m_runControls, &RunControl::displayName);
text += names.join(QLatin1Char('\n'));
m_progressLabel->setText(text);
}
void WaitForStopDialog::runControlFinished()
{
RunControl *rc = qobject_cast<RunControl *>(sender());
m_runControls.removeOne(rc);
if (m_runControls.isEmpty()) {
if (m_timer.elapsed() < 1000)
QTimer::singleShot(1000 - m_timer.elapsed(), this, &QDialog::close);
else
QDialog::close();
} else {
updateProgressText();
}
}