feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

UpdateInfo: Fix unnecessary initialization delay

Browse Source 
No need to start a one minute timer in delayedInitialize and then even
delay the next one by returning true from there.
Just start the timer in extensionsInitialized directly.

Change-Id: Ie36c8cef588603b1e9cb27a3a14db5d1dec1dae9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Eike Ziller
2018-09-28 10:16:13 +02:00
parent 25f3fe145d
commit a5d5397964
2 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/updateinfo/updateinfoplugin.cpp
View File

@@ -179,16 +179,10 @@ bool UpdateInfoPlugin::isCheckForUpdatesRunning() const
return d->m_checkUpdatesCommand; return d->m_checkUpdatesCommand;
} }
bool UpdateInfoPlugin::delayedInitialize() void UpdateInfoPlugin::extensionsInitialized()
{ {
if (isAutomaticCheck()) if (isAutomaticCheck())
QTimer::singleShot(OneMinute, this, &UpdateInfoPlugin::startAutoCheckForUpdates); QTimer::singleShot(OneMinute, this, &UpdateInfoPlugin::startAutoCheckForUpdates);
return true;
}
void UpdateInfoPlugin::extensionsInitialized()
{
} }
bool UpdateInfoPlugin::initialize(const QStringList & /* arguments */, QString *errorMessage) bool UpdateInfoPlugin::initialize(const QStringList & /* arguments */, QString *errorMessage)

1
src/plugins/updateinfo/updateinfoplugin.h
View File

@@ -52,7 +52,6 @@ public:
UpdateInfoPlugin(); UpdateInfoPlugin();
virtual ~UpdateInfoPlugin(); virtual ~UpdateInfoPlugin();
bool delayedInitialize();
void extensionsInitialized(); void extensionsInitialized();
bool initialize(const QStringList &arguments, QString *errorMessage); bool initialize(const QStringList &arguments, QString *errorMessage);