feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Avoid redundant copy

Browse Source 
Amends commit e8802d92e3.

Reported by Coverity.

Change-Id: Ibc0b1cdf1918d5bfed5104f14098096d158526e2
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
Orgad Shaneh
2023-02-21 08:57:39 +02:00
committed by Orgad Shaneh
parent 55760cb5f7
commit a5e98b1fa0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp
View File

@@ -545,7 +545,7 @@ ToolChain *findExternalToolchain(const QString &presetArchitecture, const QStrin
}; };
Abi::OSFlavor toolsetAbi = Abi::UnknownFlavor; Abi::OSFlavor toolsetAbi = Abi::UnknownFlavor;
for (auto abiPair : abiTable) { for (const auto &abiPair : abiTable) {
if (presetToolset.contains(abiPair.first)) { if (presetToolset.contains(abiPair.first)) {
toolsetAbi = abiPair.second; toolsetAbi = abiPair.second;
break; break;
@@ -554,7 +554,7 @@ ToolChain *findExternalToolchain(const QString &presetArchitecture, const QStrin
// User didn't specify any flavor, so pick the highest toolchain available // User didn't specify any flavor, so pick the highest toolchain available
if (toolsetAbi == Abi::UnknownFlavor) { if (toolsetAbi == Abi::UnknownFlavor) {
for (auto abiPair : abiTable) { for (const auto &abiPair : abiTable) {
if (msvcFlavors.contains(abiPair.second)) { if (msvcFlavors.contains(abiPair.second)) {
toolsetAbi = abiPair.second; toolsetAbi = abiPair.second;
break; break;