feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Nim: workaround to project parsing loops

Browse Source 
Nimble creates temporaries files when querying the task list
for the project files. For this reason we simply exclude
requesting a project reparse when the root directory changes

Change-Id: I6f1af3f073b056ecb2a7273fcb3df0cb44a1b53b
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Filippo Cucchetto
2020-02-17 00:18:40 +01:00
parent b9739c0945
commit a640eb8560
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/nim/project/nimblebuildsystem.cpp
View File

@@ -109,11 +109,6 @@ static NimbleMetadata parseMetadata(const QString &nimblePath, const QString &wo
NimbleBuildSystem::NimbleBuildSystem(Target *target)
: BuildSystem(target), m_projectScanner(target->project())
{
// Not called in parseProject due to nimble behavior to create temporary
// files in project directory. This creation in turn stimulate the fs watcher
// that in turn causes project parsing (thus a loop if invoke in parseProject).
// For this reason we call this function manually during project creation
// See https://github.com/nim-lang/nimble/issues/720
m_projectScanner.watchProjectFilePath();
connect(&m_projectScanner, &NimProjectScanner::fileChanged, this, [this](const QString &path) {
@@ -126,8 +121,11 @@ NimbleBuildSystem::NimbleBuildSystem(Target *target)
connect(&m_projectScanner, &NimProjectScanner::finished, this, &NimbleBuildSystem::updateProject);
connect(&m_projectScanner, &NimProjectScanner::directoryChanged, this, [this] {
if (!isWaitingForParse())
connect(&m_projectScanner, &NimProjectScanner::directoryChanged, this, [this] (const QString &directory){
// Workaround for nimble creating temporary files in project root directory
// when querying the list of tasks.
// See https://github.com/nim-lang/nimble/issues/720
if (directory != projectDirectory().toString())
requestDelayedParse();
});

2
src/plugins/nim/project/nimbuildsystem.h
View File

@@ -53,7 +53,7 @@ public:
signals:
void finished();
void requestReparse();
void directoryChanged();
void directoryChanged(const QString &path);
void fileChanged(const QString &path);
private: