feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCS: "final"-ize IVersionControl implementations

Browse Source 
Change-Id: I123a8da9b08b2fe5de679d5caac7fa20bfb0ef4a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Tobias Hunger
2016-10-20 12:38:50 +02:00
parent 72d3f4383e
commit a693bd97ef
7 changed files with 102 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/plugins/bazaar/bazaarcontrol.h
View File

@@ -45,24 +45,24 @@ class BazaarControl: public Core::IVersionControl
public: public:
explicit BazaarControl(BazaarClient *bazaarClient); explicit BazaarControl(BazaarClient *bazaarClient);
QString displayName() const override; QString displayName() const final;
Core::Id id() const override; Core::Id id() const final;
bool managesDirectory(const QString &filename, QString *topLevel = 0) const override; bool managesDirectory(const QString &filename, QString *topLevel = 0) const final;
bool managesFile(const QString &workingDirectory, const QString &fileName) const override; bool managesFile(const QString &workingDirectory, const QString &fileName) const final;
bool isConfigured() const override; bool isConfigured() const final;
bool supportsOperation(Operation operation) const override; bool supportsOperation(Operation operation) const final;
bool vcsOpen(const QString &fileName) override; bool vcsOpen(const QString &fileName) final;
bool vcsAdd(const QString &filename) override; bool vcsAdd(const QString &filename) final;
bool vcsDelete(const QString &filename) override; bool vcsDelete(const QString &filename) final;
bool vcsMove(const QString &from, const QString &to) override; bool vcsMove(const QString &from, const QString &to) final;
bool vcsCreateRepository(const QString &directory) override; bool vcsCreateRepository(const QString &directory) final;
bool vcsAnnotate(const QString &file, int line) override; bool vcsAnnotate(const QString &file, int line) final;
Core::ShellCommand *createInitialCheckoutCommand(const QString &url, Core::ShellCommand *createInitialCheckoutCommand(const QString &url,
const Utils::FileName &baseDirectory, const Utils::FileName &baseDirectory,
const QString &localName, const QString &localName,
const QStringList &extraArgs) override; const QStringList &extraArgs) final;
// To be connected to the VCSTask's success signal to emit the repository/ // To be connected to the VCSTask's success signal to emit the repository/
// files changed signals according to the variant's type: // files changed signals according to the variant's type:

34
src/plugins/clearcase/clearcasecontrol.h
View File

@@ -39,28 +39,28 @@ class ClearCaseControl : public Core::IVersionControl
Q_OBJECT Q_OBJECT
public: public:
explicit ClearCaseControl(ClearCasePlugin *plugin); explicit ClearCaseControl(ClearCasePlugin *plugin);
QString displayName() const override; QString displayName() const final;
Core::Id id() const override; Core::Id id() const final;
bool managesDirectory(const QString &directory, QString *topLevel = 0) const override; bool managesDirectory(const QString &directory, QString *topLevel = 0) const final;
bool managesFile(const QString &workingDirectory, const QString &fileName) const override; bool managesFile(const QString &workingDirectory, const QString &fileName) const final;
bool isConfigured() const override; bool isConfigured() const final;
bool supportsOperation(Operation operation) const override; bool supportsOperation(Operation operation) const final;
OpenSupportMode openSupportMode(const QString &fileName) const override; OpenSupportMode openSupportMode(const QString &fileName) const final;
bool vcsOpen(const QString &fileName) override; bool vcsOpen(const QString &fileName) final;
SettingsFlags settingsFlags() const override; SettingsFlags settingsFlags() const final;
bool vcsAdd(const QString &fileName) override; bool vcsAdd(const QString &fileName) final;
bool vcsDelete(const QString &filename) override; bool vcsDelete(const QString &filename) final;
bool vcsMove(const QString &from, const QString &to) override; bool vcsMove(const QString &from, const QString &to) final;
bool vcsCreateRepository(const QString &directory) override; bool vcsCreateRepository(const QString &directory) final;
bool vcsAnnotate(const QString &file, int line) override; bool vcsAnnotate(const QString &file, int line) final;
QString vcsOpenText() const override; QString vcsOpenText() const final;
QString vcsMakeWritableText() const override; QString vcsMakeWritableText() const final;
QString vcsTopic(const QString &directory) override; QString vcsTopic(const QString &directory) final;
void emitRepositoryChanged(const QString &); void emitRepositoryChanged(const QString &);
void emitFilesChanged(const QStringList &); void emitFilesChanged(const QStringList &);

30
src/plugins/cvs/cvscontrol.h
View File

@@ -39,28 +39,28 @@ class CvsControl : public Core::IVersionControl
public: public:
explicit CvsControl(CvsPlugin *plugin); explicit CvsControl(CvsPlugin *plugin);
QString displayName() const override; QString displayName() const final;
Core::Id id() const override; Core::Id id() const final;
bool managesDirectory(const QString &directory, QString *topLevel = 0) const override; bool managesDirectory(const QString &directory, QString *topLevel = 0) const final;
bool managesFile(const QString &workingDirectory, const QString &fileName) const override; bool managesFile(const QString &workingDirectory, const QString &fileName) const final;
bool isConfigured() const override; bool isConfigured() const final;
bool supportsOperation(Operation operation) const override; bool supportsOperation(Operation operation) const final;
OpenSupportMode openSupportMode(const QString &fileName) const override; OpenSupportMode openSupportMode(const QString &fileName) const final;
bool vcsOpen(const QString &fileName) override; bool vcsOpen(const QString &fileName) final;
bool vcsAdd(const QString &fileName) override; bool vcsAdd(const QString &fileName) final;
bool vcsDelete(const QString &filename) override; bool vcsDelete(const QString &filename) final;
bool vcsMove(const QString &from, const QString &to) override; bool vcsMove(const QString &from, const QString &to) final;
bool vcsCreateRepository(const QString &directory) override; bool vcsCreateRepository(const QString &directory) final;
bool vcsAnnotate(const QString &file, int line) override; bool vcsAnnotate(const QString &file, int line) final;
QString vcsOpenText() const override; QString vcsOpenText() const final;
Core::ShellCommand *createInitialCheckoutCommand(const QString &url, Core::ShellCommand *createInitialCheckoutCommand(const QString &url,
const Utils::FileName &baseDirectory, const Utils::FileName &baseDirectory,
const QString &localName, const QString &localName,
const QStringList &extraArgs) override; const QStringList &extraArgs) final;
void emitRepositoryChanged(const QString &s); void emitRepositoryChanged(const QString &s);
void emitFilesChanged(const QStringList &l); void emitFilesChanged(const QStringList &l);

30
src/plugins/git/gitversioncontrol.h
View File

@@ -39,29 +39,29 @@ class GitVersionControl : public Core::IVersionControl
public: public:
explicit GitVersionControl(GitClient *client); explicit GitVersionControl(GitClient *client);
QString displayName() const override; QString displayName() const final;
Core::Id id() const override; Core::Id id() const final;
bool managesDirectory(const QString &directory, QString *topLevel) const override; bool managesDirectory(const QString &directory, QString *topLevel) const final;
bool managesFile(const QString &workingDirectory, const QString &fileName) const override; bool managesFile(const QString &workingDirectory, const QString &fileName) const final;
bool isConfigured() const override; bool isConfigured() const final;
bool supportsOperation(Operation operation) const override; bool supportsOperation(Operation operation) const final;
bool vcsOpen(const QString &fileName) override; bool vcsOpen(const QString &fileName) final;
bool vcsAdd(const QString &fileName) override; bool vcsAdd(const QString &fileName) final;
bool vcsDelete(const QString &filename) override; bool vcsDelete(const QString &filename) final;
bool vcsMove(const QString &from, const QString &to) override; bool vcsMove(const QString &from, const QString &to) final;
bool vcsCreateRepository(const QString &directory) override; bool vcsCreateRepository(const QString &directory) final;
bool vcsAnnotate(const QString &file, int line) override; bool vcsAnnotate(const QString &file, int line) final;
QString vcsTopic(const QString &directory) override; QString vcsTopic(const QString &directory) final;
Core::ShellCommand *createInitialCheckoutCommand(const QString &url, Core::ShellCommand *createInitialCheckoutCommand(const QString &url,
const Utils::FileName &baseDirectory, const Utils::FileName &baseDirectory,
const QString &localName, const QString &localName,
const QStringList &extraArgs) override; const QStringList &extraArgs) final;
QStringList additionalToolsPath() const override; QStringList additionalToolsPath() const final;
void emitFilesChanged(const QStringList &); void emitFilesChanged(const QStringList &);
void emitRepositoryChanged(const QString &); void emitRepositoryChanged(const QString &);

26
src/plugins/mercurial/mercurialcontrol.h
View File

@@ -45,23 +45,23 @@ class MercurialControl : public Core::IVersionControl
public: public:
explicit MercurialControl(MercurialClient *mercurialClient); explicit MercurialControl(MercurialClient *mercurialClient);
QString displayName() const override; QString displayName() const final;
Core::Id id() const override; Core::Id id() const final;
bool managesDirectory(const QString &filename, QString *topLevel = 0) const override; bool managesDirectory(const QString &filename, QString *topLevel = 0) const final;
bool managesFile(const QString &workingDirectory, const QString &fileName) const override; bool managesFile(const QString &workingDirectory, const QString &fileName) const final;
bool isConfigured() const override; bool isConfigured() const final;
bool supportsOperation(Operation operation) const override; bool supportsOperation(Operation operation) const final;
bool vcsOpen(const QString &fileName) override; bool vcsOpen(const QString &fileName) final;
bool vcsAdd(const QString &filename) override; bool vcsAdd(const QString &filename) final;
bool vcsDelete(const QString &filename) override; bool vcsDelete(const QString &filename) final;
bool vcsMove(const QString &from, const QString &to) override; bool vcsMove(const QString &from, const QString &to) final;
bool vcsCreateRepository(const QString &directory) override; bool vcsCreateRepository(const QString &directory) final;
bool vcsAnnotate(const QString &file, int line) override; bool vcsAnnotate(const QString &file, int line) final;
Core::ShellCommand *createInitialCheckoutCommand(const QString &url, Core::ShellCommand *createInitialCheckoutCommand(const QString &url,
const Utils::FileName &baseDirectory, const Utils::FileName &baseDirectory,
const QString &localName, const QString &localName,
const QStringList &extraArgs) override; const QStringList &extraArgs) final;
bool sccManaged(const QString &filename); bool sccManaged(const QString &filename);

32
src/plugins/perforce/perforceversioncontrol.h
View File

@@ -38,24 +38,24 @@ class PerforceVersionControl : public Core::IVersionControl
public: public:
explicit PerforceVersionControl(PerforcePlugin *plugin); explicit PerforceVersionControl(PerforcePlugin *plugin);
QString displayName() const override; QString displayName() const final;
Core::Id id() const override; Core::Id id() const final;
bool managesDirectory(const QString &directory, QString *topLevel = 0) const override; bool managesDirectory(const QString &directory, QString *topLevel = 0) const final;
bool managesFile(const QString &workingDirectory, const QString &fileName) const override; bool managesFile(const QString &workingDirectory, const QString &fileName) const final;
bool isConfigured() const override; bool isConfigured() const final;
bool supportsOperation(Operation operation) const override; bool supportsOperation(Operation operation) const final;
OpenSupportMode openSupportMode(const QString &fileName) const override; OpenSupportMode openSupportMode(const QString &fileName) const final;
bool vcsOpen(const QString &fileName) override; bool vcsOpen(const QString &fileName) final;
SettingsFlags settingsFlags() const override; SettingsFlags settingsFlags() const final;
bool vcsAdd(const QString &fileName) override; bool vcsAdd(const QString &fileName) final;
bool vcsDelete(const QString &filename) override; bool vcsDelete(const QString &filename) final;
bool vcsMove(const QString &from, const QString &to) override; bool vcsMove(const QString &from, const QString &to) final;
bool vcsCreateRepository(const QString &directory) override; bool vcsCreateRepository(const QString &directory) final;
bool vcsAnnotate(const QString &file, int line) override; bool vcsAnnotate(const QString &file, int line) final;
QString vcsOpenText() const override; QString vcsOpenText() const final;
QString vcsMakeWritableText() const override; QString vcsMakeWritableText() const final;
void emitRepositoryChanged(const QString &s); void emitRepositoryChanged(const QString &s);
void emitFilesChanged(const QStringList &l); void emitFilesChanged(const QStringList &l);

26
src/plugins/subversion/subversioncontrol.h
View File

@@ -38,26 +38,26 @@ class SubversionControl : public Core::IVersionControl
Q_OBJECT Q_OBJECT
public: public:
explicit SubversionControl(SubversionPlugin *plugin); explicit SubversionControl(SubversionPlugin *plugin);
QString displayName() const override; QString displayName() const final;
Core::Id id() const override; Core::Id id() const final;
bool managesDirectory(const QString &directory, QString *topLevel = 0) const override; bool managesDirectory(const QString &directory, QString *topLevel = 0) const final;
bool managesFile(const QString &workingDirectory, const QString &fileName) const override; bool managesFile(const QString &workingDirectory, const QString &fileName) const final;
bool isConfigured() const override; bool isConfigured() const final;
bool supportsOperation(Operation operation) const override; bool supportsOperation(Operation operation) const final;
bool vcsOpen(const QString &fileName) override; bool vcsOpen(const QString &fileName) final;
bool vcsAdd(const QString &fileName) override; bool vcsAdd(const QString &fileName) final;
bool vcsDelete(const QString &filename) override; bool vcsDelete(const QString &filename) final;
bool vcsMove(const QString &from, const QString &to) override; bool vcsMove(const QString &from, const QString &to) final;
bool vcsCreateRepository(const QString &directory) override; bool vcsCreateRepository(const QString &directory) final;
bool vcsAnnotate(const QString &file, int line) override; bool vcsAnnotate(const QString &file, int line) final;
Core::ShellCommand *createInitialCheckoutCommand(const QString &url, Core::ShellCommand *createInitialCheckoutCommand(const QString &url,
const Utils::FileName &baseDirectory, const Utils::FileName &baseDirectory,
const QString &localName, const QString &localName,
const QStringList &extraArgs) override; const QStringList &extraArgs) final;
void emitRepositoryChanged(const QString &); void emitRepositoryChanged(const QString &);
void emitFilesChanged(const QStringList &); void emitFilesChanged(const QStringList &);