feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Make method naming more consistent.

Browse Source 
* Use id() for methods returning a string used to represent
    some type of object.
  * Use displayName() for strings that are meant to be user
    visible.
  * Quieten some warnings while touching the files anyway.
  * Move Factories to their products in the plugins where that
    was not done before.

Reviewed-by: dt
This commit is contained in:
Tobias Hunger
2010-01-07 18:17:24 +01:00
parent 8bb87fcda4
commit a6ad773722
332 changed files with 1666 additions and 1543 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/genericprojectmanager/genericprojectfileseditor.cpp
View File

@@ -77,16 +77,21 @@ QStringList ProjectFilesFactory::mimeTypes() const
return m_mimeTypes;
}
QString ProjectFilesFactory::kind() const
QString ProjectFilesFactory::id() const
{
return QLatin1String(Constants::FILES_EDITOR);
return QLatin1String(Constants::FILES_EDITOR_ID);
}
QString ProjectFilesFactory::displayName() const
{
return tr(Constants::FILES_EDITOR_DISPLAY_NAME);
}
Core::IFile *ProjectFilesFactory::open(const QString &fileName)
{
Core::EditorManager *editorManager = Core::EditorManager::instance();
if (Core::IEditor *editor = editorManager->openEditor(fileName, kind()))
if (Core::IEditor *editor = editorManager->openEditor(fileName, id()))
return editor->file();
return 0;
@@ -111,9 +116,9 @@ QList<int> ProjectFilesEditable::context() const
return m_context;
}
const char *ProjectFilesEditable::kind() const
QString ProjectFilesEditable::id() const
{
return Constants::FILES_EDITOR;
return QLatin1String(Constants::FILES_EDITOR_ID);
}
bool ProjectFilesEditable::duplicateSupported() const