feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Make method naming more consistent.

Browse Source 
* Use id() for methods returning a string used to represent
    some type of object.
  * Use displayName() for strings that are meant to be user
    visible.
  * Quieten some warnings while touching the files anyway.
  * Move Factories to their products in the plugins where that
    was not done before.

Reviewed-by: dt
This commit is contained in:
Tobias Hunger
2010-01-07 18:17:24 +01:00
parent 8bb87fcda4
commit a6ad773722
332 changed files with 1666 additions and 1543 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/qt4projectmanager/qmakestep.cpp
View File

@@ -161,7 +161,7 @@ void QMakeStep::run(QFutureInterface<bool> &fi)
AbstractProcessStep::run(fi);
}
QString QMakeStep::name()
QString QMakeStep::id()
{
return QLatin1String(Constants::QMAKESTEP);
}
@@ -374,14 +374,14 @@ QMakeStepFactory::~QMakeStepFactory()
{
}
bool QMakeStepFactory::canCreate(const QString & name) const
bool QMakeStepFactory::canCreate(const QString &id) const
{
return (name == Constants::QMAKESTEP);
return (id == Constants::QMAKESTEP);
}
ProjectExplorer::BuildStep *QMakeStepFactory::create(BuildConfiguration *bc, const QString & name) const
ProjectExplorer::BuildStep *QMakeStepFactory::create(BuildConfiguration *bc, const QString &id) const
{
Q_UNUSED(name)
Q_UNUSED(id);
return new QMakeStep(bc);
}
@@ -398,9 +398,9 @@ QStringList QMakeStepFactory::canCreateForBuildConfiguration(ProjectExplorer::Bu
return QStringList();
}
QString QMakeStepFactory::displayNameForName(const QString &name) const
QString QMakeStepFactory::displayNameForId(const QString &id) const
{
Q_UNUSED(name);
Q_UNUSED(id);
return tr("QMake");
}