forked from qt-creator/qt-creator
Make method naming more consistent.
* Use id() for methods returning a string used to represent
some type of object.
* Use displayName() for strings that are meant to be user
visible.
* Quieten some warnings while touching the files anyway.
* Move Factories to their products in the plugins where that
was not done before.
Reviewed-by: dt
This commit is contained in:
@@ -104,28 +104,28 @@ TextEditorSettings::TextEditorSettings(QObject *parent)
|
||||
formatDescriptions.append(FormatDescription(QLatin1String(C_DIFF_LOCATION), tr("Diff Location"), Qt::blue));
|
||||
|
||||
const QString category = QLatin1String(Constants::TEXT_EDITOR_SETTINGS_CATEGORY);
|
||||
const QString trCategory = QCoreApplication::translate("TextEditor", Constants::TEXT_EDITOR_SETTINGS_TR_CATEGORY);
|
||||
const QString displayCategory = QCoreApplication::translate("TextEditor", Constants::TEXT_EDITOR_SETTINGS_TR_CATEGORY);
|
||||
|
||||
m_fontSettingsPage = new FontSettingsPage(formatDescriptions,
|
||||
QLatin1String("A.FontSettings"),
|
||||
category, trCategory, this);
|
||||
category, displayCategory, this);
|
||||
pm->addObject(m_fontSettingsPage);
|
||||
|
||||
// Add the GUI used to configure the tab, storage and interaction settings
|
||||
TextEditor::BehaviorSettingsPageParameters behaviorSettingsPageParameters;
|
||||
behaviorSettingsPageParameters.id = QLatin1String("B.BehaviourSettings");
|
||||
behaviorSettingsPageParameters.name = tr("Behavior");
|
||||
behaviorSettingsPageParameters.displayName = tr("Behavior");
|
||||
behaviorSettingsPageParameters.category = category;
|
||||
behaviorSettingsPageParameters.trCategory = trCategory;
|
||||
behaviorSettingsPageParameters.displayCategory = displayCategory;
|
||||
behaviorSettingsPageParameters.settingsPrefix = QLatin1String("text");
|
||||
m_behaviorSettingsPage = new BehaviorSettingsPage(behaviorSettingsPageParameters, this);
|
||||
pm->addObject(m_behaviorSettingsPage);
|
||||
|
||||
TextEditor::DisplaySettingsPageParameters displaySettingsPageParameters;
|
||||
displaySettingsPageParameters.id = QLatin1String("D.DisplaySettings"),
|
||||
displaySettingsPageParameters.name = tr("Display");
|
||||
displaySettingsPageParameters.displayName = tr("Display");
|
||||
displaySettingsPageParameters.category = category;;
|
||||
displaySettingsPageParameters.trCategory = trCategory;
|
||||
displaySettingsPageParameters.displayCategory = displayCategory;
|
||||
displaySettingsPageParameters.settingsPrefix = QLatin1String("text");
|
||||
m_displaySettingsPage = new DisplaySettingsPage(displaySettingsPageParameters, this);
|
||||
pm->addObject(m_displaySettingsPage);
|
||||
|
||||
Reference in New Issue
Block a user