feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ExtensionManager: Set icon background green or grey depending of state

Browse Source 
This change sets green vs. grey background for extension icons depending
of enabled state.

Change-Id: Id99419544a00acca897aa0ad6c98d2598e4b2210
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Alessandro Portale
2024-06-26 12:25:40 +02:00
parent 3a007ee499
commit a6b7473834
4 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/extensionmanager/extensionmanagerwidget.cpp
View File

@@ -223,7 +223,7 @@ public:
const ItemType itemType = current.data(RoleItemType).value<ItemType>(); const ItemType itemType = current.data(RoleItemType).value<ItemType>();
const bool isPack = itemType == ItemTypePack; const bool isPack = itemType == ItemTypePack;
const bool isRemotePlugin = !(isPack || ExtensionsModel::pluginSpecForName(name)); const bool isRemotePlugin = !(isPack || pluginSpecForName(name));
installButton->setVisible(isRemotePlugin && !pluginData.empty()); installButton->setVisible(isRemotePlugin && !pluginData.empty());
if (installButton->isVisible()) if (installButton->isVisible())
installButton->setToolTip(pluginData.constFirst().second); installButton->setToolTip(pluginData.constFirst().second);
@@ -292,7 +292,7 @@ public:
}.attachTo(this); }.attachTo(this);
connect(m_checkBox, &QCheckBox::clicked, this, [this](bool checked) { connect(m_checkBox, &QCheckBox::clicked, this, [this](bool checked) {
ExtensionSystem::PluginSpec *spec = ExtensionsModel::pluginSpecForName(m_pluginName); ExtensionSystem::PluginSpec *spec = pluginSpecForName(m_pluginName);
if (spec == nullptr) if (spec == nullptr)
return; return;
const bool doIt = m_pluginView.data().setPluginsEnabled({spec}, checked); const bool doIt = m_pluginView.data().setPluginsEnabled({spec}, checked);
@@ -319,7 +319,7 @@ public:
private: private:
void update() void update()
{ {
const ExtensionSystem::PluginSpec *spec = ExtensionsModel::pluginSpecForName(m_pluginName); const ExtensionSystem::PluginSpec *spec = pluginSpecForName(m_pluginName);
setVisible(spec != nullptr); setVisible(spec != nullptr);
if (spec == nullptr) if (spec == nullptr)
return; return;

8
src/plugins/extensionmanager/extensionsbrowser.cpp
View File

@@ -422,10 +422,12 @@ QLabel *tfLabel(const TextFormat &tf, bool singleLine)
QGradientStops iconGradientStops(const QModelIndex &index) QGradientStops iconGradientStops(const QModelIndex &index)
{ {
const bool isVendorExtension = index.data(RoleVendor).toString() == "The Qt Company Ltd"; const PluginSpec *ps = pluginSpecForName(index.data(RoleName).toString());
const QColor startColor = creatorColor(isVendorExtension ? Theme::Token_Gradient01_Start const bool greenGradient = ps != nullptr && ps->isEffectivelyEnabled();
const QColor startColor = creatorColor(greenGradient ? Theme::Token_Gradient01_Start
: Theme::Token_Gradient02_Start); : Theme::Token_Gradient02_Start);
const QColor endColor = creatorColor(isVendorExtension ? Theme::Token_Gradient01_End const QColor endColor = creatorColor(greenGradient ? Theme::Token_Gradient01_End
: Theme::Token_Gradient02_End); : Theme::Token_Gradient02_End);
const QGradientStops gradient = { const QGradientStops gradient = {
{0, startColor}, {0, startColor},

2
src/plugins/extensionmanager/extensionsmodel.cpp
View File

@@ -390,7 +390,7 @@ void ExtensionsModel::setExtensionsJson(const QByteArray &json)
endResetModel(); endResetModel();
} }
PluginSpec *ExtensionsModel::pluginSpecForName(const QString &pluginName) PluginSpec *pluginSpecForName(const QString &pluginName)
{ {
return findOrDefault(PluginManager::plugins(), equal(&PluginSpec::name, pluginName)); return findOrDefault(PluginManager::plugins(), equal(&PluginSpec::name, pluginName));
} }

3
src/plugins/extensionmanager/extensionsmodel.h
View File

@@ -54,12 +54,13 @@ public:
QVariant data(const QModelIndex &index, int role) const; QVariant data(const QModelIndex &index, int role) const;
void setExtensionsJson(const QByteArray &json); void setExtensionsJson(const QByteArray &json);
static ExtensionSystem::PluginSpec *pluginSpecForName(const QString &pluginName);
private: private:
class ExtensionsModelPrivate *d = nullptr; class ExtensionsModelPrivate *d = nullptr;
}; };
ExtensionSystem::PluginSpec *pluginSpecForName(const QString &pluginName);
#ifdef WITH_TESTS #ifdef WITH_TESTS
QObject *createExtensionsModelTest(); QObject *createExtensionsModelTest();
#endif #endif