From a6f944e472326a30f6eb94a57ff388de9e9cc516 Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Mon, 1 Mar 2021 16:39:53 +0100
Subject: [PATCH] Sqlite: Use emplace_back instead of push_back

It does not only removes code it should be even more optimal.

Change-Id: I819a7300ca798c3109b20c1e3bafcd19078faebd
Reviewed-by: Tapani Mattila <tapani.mattila@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
---
 src/libs/sqlite/sqlitebasestatement.h | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/src/libs/sqlite/sqlitebasestatement.h b/src/libs/sqlite/sqlitebasestatement.h
index c6baaaf4b92..c6052e20187 100644
--- a/src/libs/sqlite/sqlitebasestatement.h
+++ b/src/libs/sqlite/sqlitebasestatement.h
@@ -349,7 +349,7 @@ public:
         bindValues(queryValues...);
 
         while (BaseStatement::next())
-            pushBackToContainer<ResultTypeCount>(container);
+            emplaceBackValues<ResultTypeCount>(container);
 
         resetter.reset();
     }
@@ -448,19 +448,6 @@ private:
         return callCallable(callable, std::make_integer_sequence<int, ResultTypeCount>{});
     }
 
-    template<typename Container, int... ColumnIndices>
-    void pushBackToContainer(Container &container, std::integer_sequence<int, ColumnIndices...>)
-    {
-        using Type = typename Container::value_type;
-        container.push_back(Type(ValueGetter(*this, ColumnIndices)...));
-    }
-
-    template<int ResultTypeCount, typename Container>
-    void pushBackToContainer(Container &container)
-    {
-        pushBackToContainer(container, std::make_integer_sequence<int, ResultTypeCount>{});
-    }
-
     template<typename ValueType>
     void bindValuesByIndex(int index, const ValueType &value)
     {