From a76a4036f72fbea3c9ae072e06fad3486ff1a1ae Mon Sep 17 00:00:00 2001 From: Andre Hartmann Date: Sat, 10 Aug 2024 14:38:46 +0200 Subject: [PATCH] Git: Fix topic while pushing to newer Gerrit servers The Syntax "%topic=foo" was already introduced in Gerrit 2.6, but until recently Gerrit supported the old "refs/for/master/topic" syntax. This support was dropped at some time, I was not able to find when exactly. [1] http://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ ReleaseNotes-2.6.html Fixes: QTCREATORBUG-31411 Change-Id: I96674abf4ce946f1064a5f01173f4ea81f5317f3 Reviewed-by: Orgad Shaneh --- src/plugins/git/gerrit/gerritpushdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/git/gerrit/gerritpushdialog.cpp b/src/plugins/git/gerrit/gerritpushdialog.cpp index a1cc84c5328..08f39d5f5c7 100644 --- a/src/plugins/git/gerrit/gerritpushdialog.cpp +++ b/src/plugins/git/gerrit/gerritpushdialog.cpp @@ -307,7 +307,7 @@ QString GerritPushDialog::pushTarget() const target += '/' + selectedRemoteBranchName(); const QString topic = selectedTopic(); if (!topic.isEmpty()) - target += '/' + topic; + options << "topic=" + topic; const QStringList reviewersInput = reviewers().split(',', Qt::SkipEmptyParts); for (const QString &reviewer : reviewersInput)