feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Do no warn when debugging with MinGW

Browse Source 
Change-Id: Iee9cc2232c002ea960f05848df02ac0658017911
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Orgad Shaneh
2017-07-09 17:03:33 +03:00
committed by Orgad Shaneh
parent 671e3eba3d
commit a78fd02574
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/debugger/debuggerengine.cpp
View File

@@ -1798,14 +1798,23 @@ void DebuggerEngine::validateExecutable()
QString detailedWarning;
switch (sp->toolChainAbi.binaryFormat()) {
case Abi::PEFormat: {
if (sp->cppEngineType != CdbEngineType) {
QString preferredDebugger;
if (sp->toolChainAbi.osFlavor() == Abi::WindowsMSysFlavor) {
if (sp->cppEngineType == CdbEngineType)
preferredDebugger = "GDB";
} else if (sp->cppEngineType != CdbEngineType) {
// osFlavor() is MSVC, so the recommended debugger is CDB
preferredDebugger = "CDB";
}
if (!preferredDebugger.isEmpty()) {
warnOnInappropriateDebugger = true;
detailedWarning = tr(
"The inferior is in the Portable Executable format.\n"
"Selecting CDB as debugger would improve the debugging "
"experience for this binary format.");
"Selecting %1 as debugger would improve the debugging "
"experience for this binary format.").arg(preferredDebugger);
break;
} else if (warnOnRelease) {
}
if (warnOnRelease && sp->cppEngineType == CdbEngineType) {
if (!symbolFile.endsWith(".exe", Qt::CaseInsensitive))
symbolFile.append(".exe");
QString errorMessage;