feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Qnx: Fix slog2er parsing when logs contain \n

Browse Source 
If the logs contain a '\n' the message parts in the new lines are not displayed.
The new line messages are displayed with no buffer details and are ignored
when the parsing is processed.

Change-Id: I0e174dd5283a64c4e9b0434c06dd417f1be2c810
Reviewed-by: Tobias Nätterlund <tobias.naetterlund@kdab.com>
Reviewed-by: Nicolas Arnaud-Cormos <nicolas@kdab.com>
This commit is contained in:
El Mehdi Fekari
2013-05-29 16:52:14 +02:00
committed by Mehdi Fekari
parent 2e3e11d00b
commit a7fa0dd4b9
2 changed files with 30 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/qnx/blackberryapplicationrunner.cpp
View File

@@ -59,6 +59,7 @@ BlackBerryApplicationRunner::BlackBerryApplicationRunner(bool debugMode, BlackBe
: QObject(parent)
, m_debugMode(debugMode)
, m_slog2infoFound(false)
, m_currentLogs(false)
, m_pid(-1)
, m_appId(QString())
, m_running(false)
@@ -155,6 +156,7 @@ ProjectExplorer::RunControl::StopResult BlackBerryApplicationRunner::stop()
return ProjectExplorer::RunControl::AsynchronousStop;
m_stopping = true;
m_currentLogs = false;
if (m_testSlog2Process && m_testSlog2Process->isProcessRunning()) {
m_testSlog2Process->cancel();
@@ -312,9 +314,24 @@ void BlackBerryApplicationRunner::handleTailOutput()
if (m_slog2infoFound) {
const QStringList multiLine = message.split(QLatin1Char('\n'));
Q_FOREACH (const QString &line, multiLine) {
// Check if logs are from the recent launch
// Note: This is useless if/once slog2info -b displays only logs from recent launches
if (!m_currentLogs) {
QDateTime dateTime = QDateTime::fromString(line.split(m_appId).first().mid(4).trimmed(),
QString::fromLatin1("dd HH:mm:ss.zzz"));
if (dateTime >= m_launchDateTime) {
m_currentLogs = dateTime >= m_launchDateTime;
if (!m_currentLogs)
continue;
}
// The line could be a part of a previous log message that contains a '\n'
// In that case only the message body is displayed
if (!line.contains(m_appId) && !line.isEmpty()) {
emit output(line + QLatin1Char('\n'), Utils::StdOutFormat);
continue;
}
QStringList validLineBeginnings;
validLineBeginnings << QLatin1String("qt-msg 0 ")
<< QLatin1String("qt-msg* 0 ")
@@ -326,7 +343,6 @@ void BlackBerryApplicationRunner::handleTailOutput()
break;
}
}
}
return;
}
emit output(message, Utils::StdOutFormat);

1
src/plugins/qnx/blackberryapplicationrunner.h
View File

@@ -104,6 +104,7 @@ private:
bool m_debugMode;
bool m_slog2infoFound;
bool m_currentLogs;
QDateTime m_launchDateTime;