feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Move convenience function to only user

Browse Source 
Change-Id: I50952521bdd45faa8a31da674e7ea5f0796d75d9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2019-09-19 16:41:14 +02:00
parent b63034b551
commit a82b40e037
3 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/debugger/debuggercore.h
View File

@@ -36,7 +36,6 @@
#include <functional> #include <functional>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QMessageBox;
class QWidget; class QWidget;
class QMenu; class QMenu;
class QAction; class QAction;
@@ -71,9 +70,6 @@ bool boolSetting(int code);
QString stringSetting(int code); QString stringSetting(int code);
QStringList stringListSetting(int code); QStringList stringListSetting(int code);
QMessageBox *showMessageBox(int icon, const QString &title,
const QString &text, int buttons = 0);
QAction *addAction(QMenu *menu, const QString &display, bool on, QAction *addAction(QMenu *menu, const QString &display, bool on,
const std::function<void()> &onTriggered = {}); const std::function<void()> &onTriggered = {});
QAction *addAction(QMenu *menu, const QString &d1, const QString &d2, bool on, QAction *addAction(QMenu *menu, const QString &d1, const QString &d2, bool on,

11
src/plugins/debugger/debuggerplugin.cpp
View File

@@ -2029,17 +2029,6 @@ void DebuggerPluginPrivate::remoteCommand(const QStringList &options)
runScheduled(); runScheduled();
} }
QMessageBox *showMessageBox(int icon, const QString &title, const QString &text, int buttons)
{
QMessageBox *mb = new QMessageBox(QMessageBox::Icon(icon),
title, text, QMessageBox::StandardButtons(buttons),
ICore::mainWindow());
mb->setAttribute(Qt::WA_DeleteOnClose);
mb->setTextInteractionFlags(Qt::TextSelectableByMouse);
mb->show();
return mb;
}
void addDebugInfoTask(unsigned id, const QString &cmd) void addDebugInfoTask(unsigned id, const QString &cmd)
{ {
dd->m_debugInfoTaskHandler.addTask(id, cmd); dd->m_debugInfoTaskHandler.addTask(id, cmd);

11
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -103,6 +103,17 @@ static bool isMostlyHarmlessMessage(const QStringRef &msg)
"Invalid argument\\n"; "Invalid argument\\n";
} }
static QMessageBox *showMessageBox(QMessageBox::Icon icon,
const QString &title, const QString &text,
QMessageBox::StandardButtons buttons)
{
auto mb = new QMessageBox(icon, title, text, buttons, ICore::mainWindow());
mb->setAttribute(Qt::WA_DeleteOnClose);
mb->setTextInteractionFlags(Qt::TextSelectableByMouse);
mb->show();
return mb;
}
/////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////
// //
// GdbEngine // GdbEngine