feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

iOS: Use base IDevice::clone() instead of local toMap/fromMap

Browse Source 
Some non-persistent data is handled in the base.

Change-Id: I5f6c5429b88178115bf26f885b80fa3daebf227e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2019-05-27 10:07:10 +02:00
parent 967f20ab89
commit a889669369
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/ios/iosdevice.cpp
View File

@@ -227,14 +227,10 @@ void IosDeviceManager::deviceConnected(const QString &uid, const QString &name)
} else if (dev->deviceState() != IDevice::DeviceConnected && } else if (dev->deviceState() != IDevice::DeviceConnected &&
dev->deviceState() != IDevice::DeviceReadyToUse) { dev->deviceState() != IDevice::DeviceReadyToUse) {
qCDebug(detectLog) << "updating ios device " << uid; qCDebug(detectLog) << "updating ios device " << uid;
IosDevice *newDev = nullptr; if (dev->type() == devType) // FIXME: Should that be a QTC_ASSERT?
if (dev->type() == devType) { devManager->addDevice(dev->clone());
newDev = new IosDevice(); else
newDev->fromMap(dev->toMap()); devManager->addDevice(IDevice::ConstPtr(new IosDevice(uid)));
} else {
newDev = new IosDevice(uid);
}
devManager->addDevice(IDevice::ConstPtr(newDev));
} }
updateInfo(uid); updateInfo(uid);
} }