From a88dac86c02ea08934b48f71b5c1c9d64e47df82 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Wed, 10 Jan 2024 22:16:05 +0100
Subject: [PATCH] ModelingLib: Avoid using keys()

Instead, iterate directly over the container.

Notably, sorting the result of keys() didn't play any
significant role in this contexts.

Change-Id: Iba82f3d503143ff0036509d0bf08c87747aeb40c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
---
 src/libs/modelinglib/qmt/style/defaultstyleengine.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/libs/modelinglib/qmt/style/defaultstyleengine.cpp b/src/libs/modelinglib/qmt/style/defaultstyleengine.cpp
index 2c9e481e255..74e91837dc9 100644
--- a/src/libs/modelinglib/qmt/style/defaultstyleengine.cpp
+++ b/src/libs/modelinglib/qmt/style/defaultstyleengine.cpp
@@ -325,12 +325,10 @@ const Style *DefaultStyleEngine::applyObjectStyle(const Style *baseStyle, const
     }
     int depth = 0;
     if (!depths.isEmpty()) {
-        const QList<int> keys = Utils::sorted(depths.keys());
-        for (int d : keys) {
-            DepthProperties properties = depths.value(d);
-            if (properties.m_elementType == elementType
-                    && areStackingRoles(properties.m_visualPrimaryRole, properties.m_visualSecondaryRole,
-                                        styledVisualPrimaryRole, styledVisualSecondaryRole)) {
+        for (auto it = depths.cbegin(); it != depths.cend(); ++it) {
+            if (it->m_elementType == elementType
+                && areStackingRoles(it->m_visualPrimaryRole, it->m_visualSecondaryRole,
+                                    styledVisualPrimaryRole, styledVisualSecondaryRole)) {
                 ++depth;
             } else {
                 depth = 0;