From a8a1f036cdda16f150aed584fbbfced973a8c2a4 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Wed, 2 Feb 2022 17:35:58 +0100 Subject: [PATCH] Core: Explicitly detach QPalette in WelcomePageHelpers Workaround for QPalette behavior change Qt 6.2.2 -> 6.2.3 Task-number: QTBUG-100439 Fixes: QTCREATORBUG-26981 Change-Id: If28195023929baf7dfeb2b0196c8339b84658488 Reviewed-by: Reviewed-by: Cristian Adam --- src/plugins/coreplugin/iwelcomepage.cpp | 3 +++ src/plugins/coreplugin/welcomepagehelper.cpp | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/plugins/coreplugin/iwelcomepage.cpp b/src/plugins/coreplugin/iwelcomepage.cpp index 89c13f993c7..5ccf830ae56 100644 --- a/src/plugins/coreplugin/iwelcomepage.cpp +++ b/src/plugins/coreplugin/iwelcomepage.cpp @@ -66,6 +66,9 @@ IWelcomePage::~IWelcomePage() QPalette WelcomePageFrame::buttonPalette(bool isActive, bool isCursorInside, bool forText) { QPalette pal; + pal.setBrush(QPalette::Window, {}); + pal.setBrush(QPalette::WindowText, {}); + Theme *theme = Utils::creatorTheme(); if (isActive) { if (forText) { diff --git a/src/plugins/coreplugin/welcomepagehelper.cpp b/src/plugins/coreplugin/welcomepagehelper.cpp index e5c69d32797..d363fdf6656 100644 --- a/src/plugins/coreplugin/welcomepagehelper.cpp +++ b/src/plugins/coreplugin/welcomepagehelper.cpp @@ -81,7 +81,8 @@ QWidget *panelBar(QWidget *parent) auto frame = new QWidget(parent); frame->setAutoFillBackground(true); frame->setMinimumWidth(WelcomePageHelpers::HSpacing); - QPalette pal = frame->palette(); + QPalette pal; + pal.setBrush(QPalette::Window, {}); pal.setColor(QPalette::Window, themeColor(Theme::Welcome_BackgroundPrimaryColor)); frame->setPalette(pal); return frame;