feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix puppet crash when importing asset with commas in name

Browse Source 
Importing 3D assets doesn't need to create Qt5NodeInstanceClientProxy,
so skip that in puppet initialization as it may lead to misinterpreting
some command line parameters given to the puppet.

Fixes: QDS-13123
Change-Id: Ifa6601dfa7da1a613b2c897a287a7baeb07dd712
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This commit is contained in:
Miikka Heikkinen
2024-06-27 15:44:38 +03:00
parent 14b7df7cf2
commit a9426e1977
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/tools/qml2puppet/qml2puppet/qmlpuppet.cpp
View File

@@ -124,12 +124,12 @@ void QmlPuppet::initQmlRunner()
QString options = m_coreApp->arguments().at(4); QString options = m_coreApp->arguments().at(4);
Import3D::import3D(sourceAsset, outDir, options); Import3D::import3D(sourceAsset, outDir, options);
} } else {
startCrashpad(QCoreApplication::applicationDirPath() startCrashpad(QCoreApplication::applicationDirPath()
+ '/' + RELATIVE_LIBEXEC_PATH, crashReportsPath()); + '/' + RELATIVE_LIBEXEC_PATH, crashReportsPath());
new QmlDesigner::Qt5NodeInstanceClientProxy(m_coreApp.get()); new QmlDesigner::Qt5NodeInstanceClientProxy(m_coreApp.get());
}
#if defined(Q_OS_WIN) && defined(QT_NO_DEBUG) #if defined(Q_OS_WIN) && defined(QT_NO_DEBUG)
SetErrorMode(SEM_NOGPFAULTERRORBOX); //We do not want to see any message boxes SetErrorMode(SEM_NOGPFAULTERRORBOX); //We do not want to see any message boxes