forked from qt-creator/qt-creator
QmlDesigner: Fix puppet crash when importing asset with commas in name
Importing 3D assets doesn't need to create Qt5NodeInstanceClientProxy, so skip that in puppet initialization as it may lead to misinterpreting some command line parameters given to the puppet. Fixes: QDS-13123 Change-Id: Ifa6601dfa7da1a613b2c897a287a7baeb07dd712 Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This commit is contained in:
@@ -124,13 +124,13 @@ void QmlPuppet::initQmlRunner()
|
||||
QString options = m_coreApp->arguments().at(4);
|
||||
|
||||
Import3D::import3D(sourceAsset, outDir, options);
|
||||
} else {
|
||||
startCrashpad(QCoreApplication::applicationDirPath()
|
||||
+ '/' + RELATIVE_LIBEXEC_PATH, crashReportsPath());
|
||||
|
||||
new QmlDesigner::Qt5NodeInstanceClientProxy(m_coreApp.get());
|
||||
}
|
||||
|
||||
startCrashpad(QCoreApplication::applicationDirPath()
|
||||
+ '/' + RELATIVE_LIBEXEC_PATH, crashReportsPath());
|
||||
|
||||
new QmlDesigner::Qt5NodeInstanceClientProxy(m_coreApp.get());
|
||||
|
||||
#if defined(Q_OS_WIN) && defined(QT_NO_DEBUG)
|
||||
SetErrorMode(SEM_NOGPFAULTERRORBOX); //We do not want to see any message boxes
|
||||
#endif
|
||||
|
Reference in New Issue
Block a user