feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Editor: fix completion character completions

Browse Source 
Cleanup the proposal after an item is activated even if the proposal
widget is not visible anymore. Otherwise we might wrongly cleanup a
proposal that was triggered by a completion character while a completion
list was already open.

Change-Id: Ie95247de09313c5816cffd9a865b05183db02354
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2020-10-19 13:47:27 +02:00
parent b0d4414dfc
commit a962a08b1a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/texteditor/codeassist/codeassistant.cpp
View File

@@ -485,9 +485,10 @@ void CodeAssistantPrivate::destroyContext()
if (isWaitingForProposal()) { if (isWaitingForProposal()) {
cancelCurrentRequest(); cancelCurrentRequest();
} else if (isDisplayingProposal()) { } else if (m_proposalWidget) {
m_editorWidget->keepAutoCompletionHighlight(false); m_editorWidget->keepAutoCompletionHighlight(false);
m_proposalWidget->closeProposal(); if (m_proposalWidget->isVisible())
m_proposalWidget->closeProposal();
disconnect(m_proposalWidget, &QObject::destroyed, disconnect(m_proposalWidget, &QObject::destroyed,
this, &CodeAssistantPrivate::finalizeProposal); this, &CodeAssistantPrivate::finalizeProposal);
finalizeProposal(); finalizeProposal();