From a9750d02266ad2ca6a369a78829f3ef56e5ce10e Mon Sep 17 00:00:00 2001
From: Robert Loehning <robert.loehning@digia.com>
Date: Mon, 19 Nov 2012 12:41:48 +0100
Subject: [PATCH] Fix opening in file manager

Task-number: QTCREATORBUG-8174
Change-Id: I9858ff5c24e80ed1f4375b2f4076bc74832bb217
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
---
 src/libs/utils/unixutils.cpp         | 6 +++---
 src/plugins/coreplugin/fileutils.cpp | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/libs/utils/unixutils.cpp b/src/libs/utils/unixutils.cpp
index 0aa28797eb8..d14602ad6c9 100644
--- a/src/libs/utils/unixutils.cpp
+++ b/src/libs/utils/unixutils.cpp
@@ -77,11 +77,11 @@ QString UnixUtils::substituteFileBrowserParameters(const QString &pre, const QSt
             c = pre.at(++i);
             QString s;
             if (c == QLatin1Char('d'))
-                s = QFileInfo(file).path();
+                s = QLatin1Char('"') + QFileInfo(file).path() + QLatin1Char('"');
             else if (c == QLatin1Char('f'))
-                s = file;
+                s = QLatin1Char('"') + file + QLatin1Char('"');
             else if (c == QLatin1Char('n'))
-                s = QFileInfo(file).fileName();
+                s = QLatin1Char('"') + QFileInfo(file).fileName() + QLatin1Char('"');
             else if (c == QLatin1Char('%'))
                 s = c;
             else {
diff --git a/src/plugins/coreplugin/fileutils.cpp b/src/plugins/coreplugin/fileutils.cpp
index 4f50ee2646d..bc10b3330e3 100644
--- a/src/plugins/coreplugin/fileutils.cpp
+++ b/src/plugins/coreplugin/fileutils.cpp
@@ -95,11 +95,11 @@ void FileUtils::showInGraphicalShell(QWidget *parent, const QString &pathIn)
                                                      "Could not find explorer.exe in path to launch Windows Explorer."));
         return;
     }
-    QString param;
+    QStringList param;
     if (!QFileInfo(pathIn).isDir())
-        param = QLatin1String("/select,");
+        param += QLatin1String("/select,");
     param += QDir::toNativeSeparators(pathIn);
-    QProcess::startDetached(explorer, QStringList(param));
+    QProcess::startDetached(explorer, param);
 #elif defined(Q_OS_MAC)
     Q_UNUSED(parent)
     QStringList scriptArgs;