feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use switch in showEditValue().

Browse Source 
Change-Id: I37c628ea18663eb8fec5351e3b2d580617ff7c35
Reviewed-by: hjk <qthjk@ovi.com>
This commit is contained in:
Friedemann Kleint
2012-12-14 11:50:14 +01:00
committed by hjk
parent 224eaa817a
commit a9ea71c26f
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/plugins/debugger/watchhandler.cpp
View File

@@ -1649,12 +1649,13 @@ void WatchHandler::showEditValue(const WatchData &data)
{ {
const QByteArray key = data.address ? data.hexAddress() : data.iname; const QByteArray key = data.address ? data.hexAddress() : data.iname;
QObject *w = m_model->m_editHandlers.value(key); QObject *w = m_model->m_editHandlers.value(key);
if (data.editformat == 0x0) { switch (data.editformat) {
case StopDisplay:
m_model->m_editHandlers.remove(data.iname); m_model->m_editHandlers.remove(data.iname);
delete w; delete w;
} else if (data.editformat == DisplayImageData break;
|| data.editformat == DisplayImageFile) { case DisplayImageData:
// QImage case DisplayImageFile: { // QImage
QLabel *l = qobject_cast<QLabel *>(w); QLabel *l = qobject_cast<QLabel *>(w);
if (!l) { if (!l) {
removeSeparateWidget(w); removeSeparateWidget(w);
@@ -1692,10 +1693,11 @@ void WatchHandler::showEditValue(const WatchData &data)
l->setPixmap(QPixmap::fromImage(im)); l->setPixmap(QPixmap::fromImage(im));
l->resize(width, height); l->resize(width, height);
showSeparateWidget(l); showSeparateWidget(l);
} else if (data.editformat == DisplayUtf16String }
|| data.editformat == DisplayLatin1String break;
|| data.editformat == DisplayUtf8String) { case DisplayUtf16String:
// String data. case DisplayLatin1String:
case DisplayUtf8String: { // String data.
QTextEdit *t = qobject_cast<QTextEdit *>(w); QTextEdit *t = qobject_cast<QTextEdit *>(w);
if (!t) { if (!t) {
removeSeparateWidget(w); removeSeparateWidget(w);
@@ -1716,7 +1718,9 @@ void WatchHandler::showEditValue(const WatchData &data)
QLatin1String(data.type) : data.displayedType)); QLatin1String(data.type) : data.displayedType));
t->setText(str); t->setText(str);
showSeparateWidget(t); showSeparateWidget(t);
} else if (data.editformat == 4) { }
break;
case DisplayProcess: {
// Generic Process. // Generic Process.
int pos = data.editvalue.indexOf('|'); int pos = data.editvalue.indexOf('|');
QByteArray cmd = data.editvalue.left(pos); QByteArray cmd = data.editvalue.left(pos);
@@ -1729,8 +1733,11 @@ void WatchHandler::showEditValue(const WatchData &data)
m_model->m_editHandlers[key] = p; m_model->m_editHandlers[key] = p;
} }
p->write(input + '\n'); p->write(input + '\n');
} else { }
break;
default:
QTC_ASSERT(false, qDebug() << "Display format: " << data.editformat); QTC_ASSERT(false, qDebug() << "Display format: " << data.editformat);
break;
} }
} }