feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Bazaar: Simplify BazaarPluginPrivate::isConfigured() check

Browse Source 
Change-Id: If3e940c38149f5ae75d99582593918f4847c8c3e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2021-08-20 16:35:53 +02:00
parent 4bf6008158
commit a9f5a9c6a4
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/bazaar/bazaarplugin.cpp
View File

@@ -865,10 +865,7 @@ bool BazaarPluginPrivate::managesFile(const FilePath &workingDirectory, const QS
bool BazaarPluginPrivate::isConfigured() const bool BazaarPluginPrivate::isConfigured() const
{ {
const FilePath binary = m_settings.binaryPath.filePath(); const FilePath binary = m_settings.binaryPath.filePath();
if (binary.isEmpty()) return !binary.isEmpty() && binary.isExecutableFile();
return false;
QFileInfo fi = binary.toFileInfo();
return fi.exists() && fi.isFile() && fi.isExecutable();
} }
bool BazaarPluginPrivate::supportsOperation(Operation operation) const bool BazaarPluginPrivate::supportsOperation(Operation operation) const