feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ExtensionSystem: Add total real time to profiling report

Browse Source 
The original total only contained the time spent inside of plugin
methods, but a lot of things get delayed arbitrarily to the event loop
currently. That is included in the new "total startup".

Task-number: QTCREATORBUG-29540
Change-Id: I832bb972d85bc4cf82f098e4cbf5d3ff3800d14a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
(cherry picked from commit 026848eadd)
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Eike Ziller
2023-08-28 16:21:39 +02:00
parent 0c104914ab
commit aa4ff49f83
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/extensionsystem/pluginmanager.cpp
View File

@@ -957,6 +957,8 @@ void PluginManagerPrivate::nextDelayedInitialize()
m_isInitializationDone = true; m_isInitializationDone = true;
delete delayedInitializeTimer; delete delayedInitializeTimer;
delayedInitializeTimer = nullptr; delayedInitializeTimer = nullptr;
if (m_profileTimer)
m_totalStartupMS = m_profileTimer->elapsed();
profilingSummary(); profilingSummary();
emit q->initializationDone(); emit q->initializationDone();
#ifdef WITH_TESTS #ifdef WITH_TESTS
@@ -1814,7 +1816,8 @@ void PluginManagerPrivate::profilingSummary() const
const qint64 t = s->performanceData().total(); const qint64 t = s->performanceData().total();
qDebug("%-22s %8lldms ( %5.2f%% )", qPrintable(s->name()), t, 100.0 * t / total); qDebug("%-22s %8lldms ( %5.2f%% )", qPrintable(s->name()), t, 100.0 * t / total);
} }
qDebug("Total: %8lldms", total); qDebug("Total plugins: %8lldms", total);
qDebug("Total startup: %8lldms", m_totalStartupMS);
Utils::Benchmarker::report("loadPlugins", "Total", total); Utils::Benchmarker::report("loadPlugins", "Total", total);
} }
} }

2
src/libs/extensionsystem/pluginmanager_p.h
View File

@@ -107,6 +107,8 @@ public:
QStringList argumentsForRestart; QStringList argumentsForRestart;
QScopedPointer<QElapsedTimer> m_profileTimer; QScopedPointer<QElapsedTimer> m_profileTimer;
qint64 m_profileElapsedMS = 0; qint64 m_profileElapsedMS = 0;
qint64 m_totalUntilDelayedInitialize = 0;
qint64 m_totalStartupMS = 0;
unsigned m_profilingVerbosity = 0; unsigned m_profilingVerbosity = 0;
Utils::QtcSettings *settings = nullptr; Utils::QtcSettings *settings = nullptr;
Utils::QtcSettings *globalSettings = nullptr; Utils::QtcSettings *globalSettings = nullptr;