feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Replace bool argument with flags

Browse Source 
For a start, it's a single flag. Will be extended.

Also change the default for includeRemotes to false (most callers pass false)

Change-Id: I969f89a06b85a42c134c0232d2947d58fe19ea0d
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Orgad Shaneh
2014-01-28 23:32:23 +02:00
committed by Orgad Shaneh
parent 25ddacc238
commit aa6dd83e08
6 changed files with 27 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/git/logchangedialog.h
View File

@@ -53,9 +53,16 @@ class LogChangeWidget : public QTreeView
Q_OBJECT
public:
enum LogFlag
{
None = 0x00,
IncludeRemotes = 0x01
};
Q_DECLARE_FLAGS(LogFlags, LogFlag)
explicit LogChangeWidget(QWidget *parent = 0);
bool init(const QString &repository, const QString &commit = QString(),
bool includeRemote = true);
bool init(const QString &repository, const QString &commit = QString(), LogFlags flags = None);
QString commit() const;
int commitIndex() const;
QString earliestCommit() const;
@@ -69,7 +76,7 @@ private slots:
private:
void selectionChanged(const QItemSelection &selected, const QItemSelection &deselected);
bool populateLog(const QString &repository, const QString &commit, bool includeRemote);
bool populateLog(const QString &repository, const QString &commit, LogFlags flags);
const QStandardItem *currentItem(int column = 0) const;
QStandardItemModel *m_model;
@@ -79,11 +86,12 @@ private:
class LogChangeDialog : public QDialog
{
Q_OBJECT
public:
LogChangeDialog(bool isReset, QWidget *parent);
bool runDialog(const QString &repository, const QString &commit = QString(),
bool includeRemote = true);
LogChangeWidget::LogFlags flags = LogChangeWidget::None);
QString commit() const;
int commitIndex() const;