feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: Replace annoying URL syncing by explicit Open in Edit Mode

Browse Source 
Qt Creator was syncing the current page in Help mode to the page shown
in the side-by-side view in edit mode.
This doesn't really make sense because context is completely lost.
Instead provide the explicit option to open a help page in edit mode,
also from the external help window.

Fixes: QTCREATORBUG-19198
Change-Id: I00698bb431d5c116dd1e0e1cbdc5fbd7421ac267
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2019-09-27 12:19:55 +02:00
parent d34aee4d53
commit aad6ad8c10
4 changed files with 33 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/help/helpviewer.h
View File

@@ -63,8 +63,7 @@ public:
virtual QString title() const = 0;
virtual QUrl source() const = 0;
// metacall in HelpPlugin::updateSideBarSource
Q_INVOKABLE virtual void setSource(const QUrl &url) = 0;
virtual void setSource(const QUrl &url) = 0;
virtual void setHtml(const QString &html) = 0;